Skip to content

Improve the Writer class #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nyamsprod wants to merge 2 commits into from
Closed

Improve the Writer class #179

nyamsprod wants to merge 2 commits into from

Conversation

@nyamsprod
Copy link
Member

@nyamsprod nyamsprod commented Sep 5, 2016 •
edited
Loading

Introduction

Improve the Writer class for the 9.x version

Proposal

  • Writer::insertOne accepts an array as well as a string. This behavior can lead to bug when one developer wrongfully supply a string to the method instead of the obvious array.
  • Simplify the formatting and the validating feature of the class

Describe the fixed feature

  • Remove the ability to accepts strings as valid argument for Writer::insertOne
  • Remove the following methods:
    • Writer::removeFormatter
    • Writer::hasFormatter
    • Writer::clearFormatters
    • Writer::removeValidator
    • Writer::hasValidator
    • Writer::clearValidators

Backward Incompatible Changes

Writer::insertOne will no longer accepts a string as a possible argument

Targeted release version

9.0.0

PR Impact

Writer::insertOne will no longer accepts a string as a possible argument

Open issues

@nyamsprod nyamsprod added this to the version 9.0 milestone Sep 5, 2016
@nyamsprod
Remove string as valid argument for insertOne
178216b 
Writer::insertOne accepts a string as a valid argument.
When a string was encountered the method tried to parse it as a CSV. This
parsing would result in unexpected data if one was injecting wrong data.

By removing string conversion we improve method expectation as well as
the method performance.
@nyamsprod
Remove useless method from Writer class
f258712
@nyamsprod nyamsprod changed the title Remove string as valid argument for insertOne Improve the Writer class Sep 6, 2016
@nyamsprod nyamsprod force-pushed the master branch 3 times, most recently from fdf226a to ef7eef7 Compare January 25, 2017 13:32
@nyamsprod
Copy link
Member Author

nyamsprod commented Jan 25, 2017

This PR has been merge into the #205 so I'll close it

@nyamsprod nyamsprod closed this Jan 25, 2017
@nyamsprod nyamsprod deleted the feature/restrict-insertone branch January 25, 2017 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

discussion enhancement version 9.0

Projects

None yet

Milestone

version 9.0

Development

Successfully merging this pull request may close these issues.

1 participant

@nyamsprod