Support: FetchChargeRequest #48
Conversation
|
Merged. Please confirm whether this works in production then I will tag. |
|
@delatbabel we are using it in production right now, no complain. :) Thanks! |
|
Bit late to this but could you (@wellingguzman) explain the difference between this new FetchChargeRequest and the old FetchTransactionRequest? |
|
@cfreear whoa this is awkward, there's none, there are the same thing, I was looking for a charge requests so I made a PR. this should be remove out of the repo and I should be using Sorry for the confusion. cc. @delatbabel |
|
@wellingguzman Haha, no worries, from looking at the code I thought it was the same but it's been a while since I've used the Stripe API so wasn't sure! |
|
OK should I revert this? Will it break things for you @wellingguzman ? |
|
@delatbabel it might be best to leave this in and remove it for v3. I know it's only been in for less than a month but removing it is still a potential bc for users of v2.3.3 |
|
Noted, will do. Someone might drop in a PR with a @deprecated notice or something similar. |
|
I missed all these messages, @delatbabel unfortunately it will break things for me, I will have to switch methods. I will update my code. I will let you all know. (if necessary) |
Deprecate fetchCharge as per #48
|
@wellingguzman |
|
@cfreear thank you so much, and sorry for confusion. |
…XOL-3031 * 'master' of github.com:thephpleague/omnipay-stripe: (86 commits) Make sure Curl uses TLS >= v1.2. Fixes thephpleague#53. Deprecate fetchCharge as per thephpleague#48 * move requestId into response class + AbstractRequest::getRequestId() * test commit * test commit remove unwanted file fix wrong method to check if email is set add FetchChargeRequest Adds support for `receipt_email` option to AuthorizeRequest Supports adding user without card/source and add/update customer email Link cleanup. Adding FetchCustomerRequest, FetchCustomerRequestTest, Gateway method fetchCustomer. Implement getCode method in Response class Clarify docblocks fix typo + removed duplicated file in wrong path fix typos and improve code coverage fix another typo fix typo add missing gateway tests ... # Conflicts: # src/Omnipay/Stripe/Gateway.php # src/Omnipay/Stripe/Message/AbstractRequest.php # src/Omnipay/Stripe/Message/CreateCardRequest.php # src/Omnipay/Stripe/Message/PurchaseRequest.php # src/Omnipay/Stripe/Message/UpdateCardRequest.php # tests/Message/UpdateCardRequestTest.php
…stripe-connect-support * commit '3d21b68403fb4214cbee07d0c4be55a1bb0b1805': Make sure Curl uses TLS >= v1.2. Fixes thephpleague#53. Deprecate fetchCharge as per thephpleague#48 * move requestId into response class + AbstractRequest::getRequestId() * test commit * test commit
3 participants
Also fixed wrong method used to check if email was set.