Skip to content

Updated the example in the README so that it works.#11

Merged
there4 merged 1 commit intothere4:masterfrom
guillermoandrae:master
Oct 21, 2014
Merged

Updated the example in the README so that it works.#11
there4 merged 1 commit intothere4:masterfrom
guillermoandrae:master

Conversation

@guillermoandrae
Copy link

I spent a couple of hours trying to get this to work, not noticing that the example in the README:

  1. Extended a non-existent class name and
  2. Should have been making calls against $this->client instead of $this.

there4 pushed a commit that referenced this pull request Oct 21, 2014
Updated the example in the README for latest code changes
@there4 there4 merged commit 2694489 into there4:master Oct 21, 2014
@there4
Copy link
Collaborator

there4 commented Oct 21, 2014

Thanks for this contribution. In a recent refactor those bits changes to be more in line with Symfony testing. I really appreciate you taking the time to fix this. Much appreciated!

If you've got other suggestions for it as you use it, please let me know.

@guillermoandrae
Copy link
Author

This is one of the more useful projects I've managed to find recently. If it weren't for this, I would've moved away from Slim altogether. Nice work!

@there4
Copy link
Collaborator

there4 commented Oct 21, 2014

Thanks! I appreciate you contributing!

I really do have a special place in my heart for Slim. I've got a middleware caching object for it that I've been meaning to extract out of a project. I think you've given me the enthusiasm to get that done this week.

@there4
Copy link
Collaborator

there4 commented Oct 21, 2014

Oh, and I'll get these version tagged and bumped for composer soon.

@guillermoandrae
Copy link
Author

I'lll definitely look out for that project. And sorry I forgot to bump the
version number :(.

Guillermo A. Fisher

w. http://guillermoandraefisher.com
e. me@guillermoandraefisher.com
p. +1 757 450 8819

On Tue, Oct 21, 2014 at 3:49 PM, Craig Davis notifications@github.com
wrote:

Oh, and I'll get these version tagged and bumped for composer soon.


Reply to this email directly or view it on GitHub
#11 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants