feat: Android UI for full tunnel mode (3/3)#123
Closed
vahidlazio wants to merge 1 commit into
Closed
Conversation
Android-side changes to support Mode::Full in the UI and VPN service. - ConfigStore.kt: Mode.FULL enum variant, toJson/fromJson serialization - MhrvVpnService.kt: skip "incomplete config" check for Full mode (merged with upstream therealaleph#73 startForeground crash fix) - HomeScreen.kt: "Full tunnel (no cert)" in mode dropdown, start button enabled, script ID fields shown for full mode Depends on: Rust-side Mode::Full (separate PR). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of 3: Full Tunnel Mode
Android credential check fix for full tunnel mode. Depends on #94 (now merged).
What
Bug fix: the Android
MhrvVpnServicecredential check wasmode == APPS_SCRIPT, which meant full mode could start without deployment IDs or auth key — then silently fail at runtime when the Rust side couldn't reach Apps Script.Fix:
needsCreds = mode != GOOGLE_ONLY— bothapps_scriptandfullmodes now require credentials. Onlygoogle_only(bootstrap) skips the check.1 file changed
🤖 Generated with Claude Code