domain_fronter: drain chunked response trailers#22
Merged
therealaleph merged 1 commit intoApr 22, 2026
Merged
Conversation
Consume the final CRLF and any trailer lines after a zero-length chunk before returning a pooled upstream connection. Without this, leftover bytes from a chunked response could remain on the socket and corrupt the next response read on the reused connection. Add a regression test that reads a chunked response with a trailer and then successfully parses a second response from the same stream.
therealaleph
approved these changes
Apr 22, 2026
Owner
therealaleph
left a comment
therealaleph
left a comment
There was a problem hiding this comment.
Properly drains final CRLF and trailers so a pooled connection is safe to reuse. Clean refactor via read_crlf_line helper, regression test exercises trailer + second response on the same stream. Tests pass locally.
therealaleph
pushed a commit
that referenced
this pull request
Apr 25, 2026
Consume the final CRLF and any trailer lines after a zero-length chunk before returning a pooled upstream connection. Without this, leftover bytes from a chunked response could remain on the socket and corrupt the next response read on the reused connection. Add a regression test that reads a chunked response with a trailer and then successfully parses a second response from the same stream. Co-authored-by: freeinternet865 <free@internet865.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consume the final CRLF and any trailer lines after a zero-length chunk before returning a pooled upstream connection.
Without this, leftover bytes from a chunked response could remain on the socket and corrupt the next response read on the reused connection.
Add a regression test that reads a chunked response with a trailer and then successfully parses a second response from the same stream.
Edited and written by GPT.