ui: handle proxy task shutdown more reliably#25
Merged
therealaleph merged 1 commit intotherealaleph:mainfrom Apr 22, 2026
Merged
ui: handle proxy task shutdown more reliably#25therealaleph merged 1 commit intotherealaleph:mainfrom
therealaleph merged 1 commit intotherealaleph:mainfrom
Conversation
Log server.run() errors in the UI background task instead of silently discarding them. Also abort the task if graceful shutdown times out, and make sure a finished or stopped proxy task clears the running flag consistently without wiping the last visible stats snapshot.
therealaleph
approved these changes
Apr 22, 2026
Owner
therealaleph
left a comment
therealaleph
left a comment
There was a problem hiding this comment.
Surfaces proxy errors that were previously swallowed, forces abort on shutdown timeout, and keeps last_stats visible after stop. cargo check + tests pass locally.
therealaleph
pushed a commit
that referenced
this pull request
Apr 25, 2026
Log server.run() errors in the UI background task instead of silently discarding them. Also abort the task if graceful shutdown times out, and make sure a finished or stopped proxy task clears the running flag consistently without wiping the last visible stats snapshot. Co-authored-by: freeinternet865 <free@internet865.com>
therealaleph
added a commit
that referenced
this pull request
Apr 30, 2026
…igurable batch timeout, MHRV_AUTH_KEY hint, run.bat CLI fallback Four small fixes that address recurring user-issue patterns: - src/config.rs / src/domain_fronter.rs: auto_blacklist_strikes, auto_blacklist_window_secs, auto_blacklist_cooldown_secs config fields (#391, #444). Previously 3 strikes / 30s window / 120s cooldown were hard-coded. Single-deployment users on flaky networks hit this too aggressively; multi-deployment users want tighter fail-fast. Defaults preserve historical behavior. Power-user file edit only — no UI control yet. Clamps to [1, 86400] for durations. - src/config.rs / src/domain_fronter.rs / src/tunnel_client.rs: request_timeout_secs config field (#430, masterking32 PR #25). Replaces hard-coded BATCH_TIMEOUT 30s. DomainFronter::batch_timeout() exposes the value, fire_batch reads it. Clamped to [5s, 300s]. - tunnel-node/src/main.rs: detect MHRV_AUTH_KEY env var being set while TUNNEL_AUTH_KEY is unset, and emit a specific warning pointing at the right env var name. Catches the recurring #391/#444 docker run typo that made users chase phantom AUTH_KEY-mismatch decoys. - assets/launchers/run.bat: when both UI renderers (glow + wgpu) fail on older Windows / RDP / VM-without-GPU, fall back to launching mhrv-rs.exe (CLI) instead of just printing "open an issue". Addresses #417 / #426 / #487. CLI has the same proxy functionality on 127.0.0.1:8085 (HTTP) / :8086 (SOCKS5). 169 mhrv-rs lib tests + 33 tunnel-node tests still passing. UI build clean. ConfigWire round-trips the new fields with skip-default-on-write so unchanged configs stay clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log server.run() errors in the UI background task instead of silently discarding them.
Also abort the task if graceful shutdown times out, and make sure a finished or stopped proxy task clears the running flag consistently without wiping the last visible stats snapshot.
Edited and written by GPT.