proxy: fix google_only plain HTTP content length#70
Merged
therealaleph merged 3 commits intoApr 23, 2026
Merged
Conversation
added 3 commits
April 23, 2026 15:35
The google_only 502 response for plain HTTP requests advertised Content-Length: 128 even though the body is 120 bytes. Some clients can treat that as a truncated response and wait for bytes that never arrive. This mismatch was first introduced in #62.
Add a regression test for the google_only plain-HTTP 502 response framing. It exercises the real handle_http_client path and verifies the response body's byte count matches the advertised Content-Length. This covers the Content-Length mismatch first introduced in #62.
This reverts commit db09261c76889ffea3a8930f429922f066b25d2a.
Contributor
Author
|
I pushed the test and then reverted it, so you can evaluate it yourself if needed; however, I believe including it in the final merge would have been unnecessary and disproportionate to the scope of the fix. |
therealaleph
pushed a commit
that referenced
this pull request
Apr 25, 2026
Body is exactly 120 bytes; header was advertising 128. Some clients treat that as truncated and hang waiting for extra bytes. Regression from #62.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The google_only 502 response for plain HTTP requests advertised Content-Length: 128 even though the body is 120 bytes. Some clients can treat that as a truncated response and wait for bytes that never arrive.
This mismatch was first introduced in #62.
@dazzling-no-more