Fix plugin crash on large CodeGeneratorRequest input#20
Merged
kafkiansky merged 5 commits intothesis-php:0.1.xfrom Mar 24, 2026
Merged
Fix plugin crash on large CodeGeneratorRequest input#20kafkiansky merged 5 commits intothesis-php:0.1.xfrom
kafkiansky merged 5 commits intothesis-php:0.1.xfrom
Conversation
Replace amphp's non-blocking ByteStream\buffer(ByteStream\getStdin()) with synchronous stream_get_contents(STDIN) to prevent premature EOF detection on pipe reads exceeding ~250KB. amphp's ReadableResourceStream sets STDIN to non-blocking mode and permanently closes the stream when feof() returns true — even transiently. On large pipe payloads that exceed the OS pipe buffer, fread() can drain the buffer faster than protoc writes, causing a spurious EOF (see amphp/byte-stream#47). Fixes thesis-php#19
Contributor
Author
|
@kafkiansky additionally we can use native functions in |
kafkiansky
approved these changes
Mar 24, 2026
Contributor
|
Thank you, @zlodes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ByteStream\buffer(ByteStream\getStdin())with synchronousstream_get_contents(STDIN)to prevent premature EOF detection on pipe reads exceeding ~250KBRoot cause
amphp's
ReadableResourceStreamsets STDIN to non-blocking mode and permanently closes the stream whenfeof()returnstrue— even transiently. On large pipe payloads that exceed the OS pipe buffer,fread()can drain the buffer faster than protoc writes, causing a spurious EOF. This is the same class of bug as amphp/byte-stream#47.STDIN reading is inherently synchronous for protoc plugins (protoc sends the full request before expecting a response), so non-blocking I/O provides no benefit here.
Fixes #19