Skip to content

Conversation

@Flimm
Copy link
Contributor

@Flimm Flimm commented Mar 30, 2017

This fixes #35

Note, that this is still far from an SH-compatible parser, but this at least fixes this particular issue.

To be an SH-compatible parser, these kinds of things would have to be fixed:

  • HELLO=WORLD shoud be treated differently from HELLO= WORLD
  • HELLO=${WORLD} should be treated differently from HELLO='${WORLD}'
  • The parsing of a POSIX variable should take a previous POSIX variable in precedence over an environment variable.
  • And so on.

@coveralls
Copy link

coveralls commented Mar 30, 2017

Coverage Status

Coverage remained the same at 82.418% when pulling a2096aa on Flimm:naive-single-quotes into 9552db8 on theskumar:master.

@theskumar
Copy link
Owner

@Flimm At the first look it does not seem to fix the issue where parser keeps the ' quote around the value when reading the .env file. thoughts?

@Flimm
Copy link
Contributor Author

Flimm commented Mar 30, 2017

Sorry, you're right, I forgot to push a third commit. 😳 Have a look now.

@coveralls
Copy link

coveralls commented Mar 30, 2017

Coverage Status

Coverage remained the same at 82.418% when pulling 9b5582e on Flimm:naive-single-quotes into 9552db8 on theskumar:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.418% when pulling 9b5582e on Flimm:naive-single-quotes into 9552db8 on theskumar:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.418% when pulling 9b5582e on Flimm:naive-single-quotes into 9552db8 on theskumar:master.

@theskumar
Copy link
Owner

This is looks pretty good. Love the tests 😍 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong parsing of env variables in single quotes

3 participants