Dell Inspiron 7640 Bottom Speakers Not Working / TAS2781 / ALC3254

[djmenig]

My Dell Inspiron 7640 bottom speakers have never worked with any Linux distro. My issue is very similar to #5271

As this is my first post with the SOF Project, I'm not sure which information is the best to aid in correcting the bug, but here is some relevant information:

lspci -vnn | grep -A10 -i audio
0000:00:1f.3 Multimedia audio controller [0401]: Intel Corporation Meteor Lake-P HD Audio Controller [8086:7e28] (rev 20)
        Subsystem: Dell Device [1028:0c96]
        Flags: bus master, fast devsel, latency 64, IRQ 242, IOMMU group 15
        Memory at 501c310000 (64-bit, non-prefetchable) [size=16K]
        Memory at 501c000000 (64-bit, non-prefetchable) [size=2M]
        Capabilities: <access denied>
        Kernel driver in use: sof-audio-pci-intel-mtl
        Kernel modules: snd_hda_intel, snd_sof_pci_intel_mtl

0000:00:1f.4 SMBus [0c05]: Intel Corporation Meteor Lake-P SMBus Controller [8086:7e22] (rev 20)
        Subsystem: Dell Device [1028:0c96]
        Flags: medium devsel, IRQ 18, IOMMU group 15
        Memory at 501c31c000 (64-bit, non-prefetchable) [size=256]
        I/O ports at efa0 [size=32]
        Kernel driver in use: i801_smbus
        Kernel modules: i2c_i801

dmesg | grep audio
[    5.418423] [    T915] sof-audio-pci-intel-mtl 0000:00:1f.3: enabling device (0000 -> 0002)
[    5.418593] [    T915] sof-audio-pci-intel-mtl 0000:00:1f.3: DSP detected with PCI class/subclass/prog-if 0x040100
[    5.418638] [    T915] sof-audio-pci-intel-mtl 0000:00:1f.3: bound 0000:00:02.0 (ops i915_audio_component_bind_ops [i915])
[    5.425506] [    T525] sof-audio-pci-intel-mtl 0000:00:1f.3: use msi interrupt mode
[    5.460420] [    T525] sof-audio-pci-intel-mtl 0000:00:1f.3: hda codecs found, mask 5
[    5.460422] [    T525] sof-audio-pci-intel-mtl 0000:00:1f.3: using HDA machine driver skl_hda_dsp_generic now
[    5.460424] [    T525] sof-audio-pci-intel-mtl 0000:00:1f.3: NHLT device BT(0) detected, ssp_mask 0x4
[    5.460425] [    T525] sof-audio-pci-intel-mtl 0000:00:1f.3: BT link detected in NHLT tables: 0x4
[    5.460426] [    T525] sof-audio-pci-intel-mtl 0000:00:1f.3: DMICs detected in NHLT tables: 2
[    5.463129] [    T525] sof-audio-pci-intel-mtl 0000:00:1f.3: Firmware paths/files for ipc type 1:
[    5.463131] [    T525] sof-audio-pci-intel-mtl 0000:00:1f.3:  Firmware file:     intel/sof-ipc4/mtl/sof-mtl.ri
[    5.463131] [    T525] sof-audio-pci-intel-mtl 0000:00:1f.3:  Firmware lib path: intel/sof-ipc4-lib/mtl
[    5.463132] [    T525] sof-audio-pci-intel-mtl 0000:00:1f.3:  Topology file:     intel/sof-ace-tplg/sof-hda-generic-2ch.tplg
[    5.463678] [    T525] sof-audio-pci-intel-mtl 0000:00:1f.3: Loaded firmware library: ADSPFW, version: 2.12.0.1
[    5.587371] [    T525] sof-audio-pci-intel-mtl 0000:00:1f.3: Booted firmware version: 2.12.0.1
[    5.617838] [    T876] sof-audio-pci-intel-mtl 0000:00:1f.3: Topology: ABI 3:29:1 Kernel ABI 3:23:1
[    5.648822] [    T876] snd_hda_codec_realtek ehdaudio0D0: ALC3254: picked fixup  for PCI SSID 1028:0c96
[    5.648975] [    T876] snd_hda_codec_realtek ehdaudio0D0: bound i2c-TIAS2781:00 (ops tas2781_hda_comp_ops [snd_hda_scodec_tas2781_i2c])
[    5.649229] [    T876] snd_hda_codec_realtek ehdaudio0D0: autoconfig for ALC3254: line_outs=1 (0x14/0x0/0x0/0x0/0x0) type:speaker
[    5.649233] [    T876] snd_hda_codec_realtek ehdaudio0D0:    speaker_outs=0 (0x0/0x0/0x0/0x0/0x0)
[    5.649234] [    T876] snd_hda_codec_realtek ehdaudio0D0:    hp_outs=1 (0x21/0x0/0x0/0x0/0x0)
[    5.649235] [    T876] snd_hda_codec_realtek ehdaudio0D0:    mono: mono_out=0x0
[    5.649236] [    T876] snd_hda_codec_realtek ehdaudio0D0:    inputs:

[ujfalusi]

@djmenig, have you tried the solution on the linked issue? Your description appears to be identical.

[djmenig]

@djmenig, have you tried the solution on the linked issue? Your description appears to be identical.

@ujfalusi, I have not. I could be wrong, but it looks like my device ID is different than the device ID the referenced patch is used for. It looks like my device (0c96) already has its quirk. From my dmesg outputs, it looks as though all the firmware issues that were brought up in the linked issue have been fixed. However, the snd_hda_codec_realtek ehdaudio0D0: speaker_outs=0 (0x0/0x0/0x0/0x0/0x0) line seems suspect. I'm probably completely off the mark though!

Either way I will try the patch when I find some time to patch the kernel. It'll be my first kernel patch, so I need a little bit to learn how to do it! :)

[ujfalusi]

You can try something like:

- SND_PCI_QUIRK(0x1028, 0x0c96, "Dell Polaris 2in1", ALC287_FIXUP_TAS2781_I2C),
+ SND_PCI_QUIRK(0x1028, 0x0c96, "Dell Polaris 2in1", ALC295_FIXUP_DELL_TAS2781_I2C),

after applying the patch form #5271 (comment) and to make sure that the TI firmware is loaded.

[sinkfever]

here's a patch i put together including the 0c94 and 0c96 patches, which seems to work for me.
tested this with the gentoo-sources kernel running 6.14.5.

--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7880,6 +7880,7 @@
 	ALC236_FIXUP_DELL_DUAL_CODECS,
 	ALC287_FIXUP_CS35L41_I2C_2_THINKPAD_ACPI,
 	ALC287_FIXUP_TAS2781_I2C,
+	ALC295_FIXUP_DELL_TAS2781_I2C,
 	ALC245_FIXUP_TAS2781_SPI_2,
 	ALC287_FIXUP_YOGA7_14ARB7_I2C,
 	ALC245_FIXUP_HP_MUTE_LED_COEFBIT,
@@ -9321,6 +9322,12 @@
 		.type = HDA_FIXUP_FUNC,
 		.v.func = alc294_fixup_gx502_hp,
 	},
+	[ALC295_FIXUP_DELL_TAS2781_I2C] = {
+		.type = HDA_FIXUP_FUNC,
+		.v.func = tas2781_fixup_i2c,
+		.chained = true,
+		.chain_id = ALC289_FIXUP_DUAL_SPK
+	},
 	[ALC294_FIXUP_ASUS_GU502_PINS] = {
 		.type = HDA_FIXUP_PINS,
 		.v.pins = (const struct hda_pintbl[]) {
@@ -10381,8 +10388,8 @@
 	SND_PCI_QUIRK(0x1028, 0x0c1e, "Dell Precision 3540", ALC236_FIXUP_DELL_DUAL_CODECS),
 	SND_PCI_QUIRK(0x1028, 0x0c28, "Dell Inspiron 16 Plus 7630", ALC295_FIXUP_DELL_INSPIRON_TOP_SPEAKERS),
 	SND_PCI_QUIRK(0x1028, 0x0c4d, "Dell", ALC287_FIXUP_CS35L41_I2C_4),
-	SND_PCI_QUIRK(0x1028, 0x0c94, "Dell Polaris 3 metal", ALC287_FIXUP_TAS2781_I2C),
-	SND_PCI_QUIRK(0x1028, 0x0c96, "Dell Polaris 2in1", ALC287_FIXUP_TAS2781_I2C),
+	SND_PCI_QUIRK(0x1028, 0x0c94, "Dell Polaris 3 metal", ALC295_FIXUP_DELL_TAS2781_I2C),
+	SND_PCI_QUIRK(0x1028, 0x0c96, "Dell Polaris 2in1", ALC295_FIXUP_DELL_TAS2781_I2C),
 	SND_PCI_QUIRK(0x1028, 0x0cbd, "Dell Oasis 13 CS MTL-U", ALC289_FIXUP_DELL_CS35L41_SPI_2),
 	SND_PCI_QUIRK(0x1028, 0x0cbe, "Dell Oasis 13 2-IN-1 MTL-U", ALC289_FIXUP_DELL_CS35L41_SPI_2),
 	SND_PCI_QUIRK(0x1028, 0x0cbf, "Dell Oasis 13 Low Weight MTU-L", ALC289_FIXUP_DELL_CS35L41_SPI_2),

[djmenig]

@sinkfever Thank you! The patch worked! I tested on openSUSE 6.14.6 default kernel.

My apologies for taking so long to reply to the thread. It took me a while to find the time to learn and get the kernel to build properly.

Is there anyway I can help get this patch to upstream?

[sinkfever]

No problem!

I'm not too sure on how to get patches to upstream, since I've never really worked with getting patches to upstream before.

[djmenig]

No problem!

I'm not too sure on how to get patches to upstream, since I've never really worked with getting patches to upstream before.

No worries! I'll try and track down the relevant maintainers so I can somehow get it upstreamed, or at the very least, perform a PR.

[sinkfever]

No problem!
I'm not too sure on how to get patches to upstream, since I've never really worked with getting patches to upstream before.

No worries! I'll try and track down the relevant maintainers so I can somehow get it upstreamed, or at the very least, perform a PR.

Sounds good, let me know if you need me to help out on something.

[djmenig]

Has anyone had any success patching a 6.16 kernel with the 0c94 and 0c96 patches? The patch seems to work, but then has no effect on 6.16 for me.

[sinkfever]

Currently on a 6.16.4 Gentoo kernel, everything still seems to work. I do know that the file directory structure will change in 6.17, so the said file to be patched will be in a different location. Other than that, 6.16 still works for me. Are you still using the same patch from above?