ASOC: SOF: add a workaround to detect HDA HDMI codecs by RanderWang · Pull Request #172 · thesofproject/linux

RanderWang · 2018-09-30T08:06:31Z

The initialization process of HDA in SOF is:
(1) init HDA to set up a context for i915 initialization
then stop HDA bus.

(2) init i915 to init HDMI codecs.

(3) init HDA again to make everything ready

On WHL, only HDA analog codec is detected in step (1).
And after step (2) HDMI could be detected. But in function
azx_reset for step(3), the detection code is:

/* detect codecs */
if (!bus->codec_mask) {
bus->codec_mask = snd_hdac_chip_readw(bus, STATESTS);

dev_dbg(bus->dev, "codec_mask = 0x%lx\n",
bus->codec_mask);

}

At step (3) codec_mask is not zero, so no more query would
be triggered. This results to miss detecting HDMI codecs.
Now set codec_mask to zero to query again

For GLK, none codec is detected at step(1), so it is no problem
at step(3)

Signed-off-by: Rander Wang rander.wang@linux.intel.com

RanderWang · 2018-09-30T08:09:19Z

It is a workaround. Next I will discuss with Takashi why codec_mask needs to be checked when querying codecs.

keyonjie · 2018-10-08T05:07:02Z

this looks fine to me at the moment, please send mail to alsa-devel to align solution with Takashi.

RanderWang · 2018-10-08T07:13:06Z

@lgirdwood hi Liam, can you help to review this patch?
And can you do me a favor to send a invitation email to me? Thanks

lgirdwood · 2018-10-08T13:59:03Z

@RanderWang just to confirm, we detect codecs at step 1 and HDMI at step 2 ? So to me I would replace the //FIXME comments in the code above and also add your commit message explanation as the comments stating what is detected where. This makes it obvious to any reader why the bus is reset twice etc.

@RanderWang just to confirm, we detect codecs at step 1 and HDMI at step 2 ? So to me I would replace the //FIXME comments in the code above and also add your commit message explanation as the comments stating what is detected where. This makes it obvious to any reader why the bus is reset twice etc.

yes, two steps to detect all codecs. It is good to refine my comments and I will update it

sorry @RanderWang , I mean you have a large comment with 3 steps, each comment step should be next to the line of code that does that step and not all in one place.

RanderWang · 2018-10-09T05:26:42Z

update my patch, thanks for review

RanderWang · 2018-10-15T06:29:14Z

PING

The initialization process of HDA in SOF is: (1) init HDA to set up a context for i915 initialization then stop HDA bus. (2) init i915 to init HDMI codecs. (3) init HDA again to make everything ready On WHL, only HDA analog codec is detected in step (1). And after step (2) HDMI could be detected. But in function azx_reset for step(3), the detection code is: /* detect codecs */ if (!bus->codec_mask) { bus->codec_mask = snd_hdac_chip_readw(bus, STATESTS); dev_dbg(bus->dev, "codec_mask = 0x%lx\n", bus->codec_mask); } At step (3) codec_mask is not zero, so no more query would be triggered. This results to miss detecting HDMI codecs. Now set codec_mask to zero to query again For GLK, none codec is detected at step(1), so it is no problem at step(3) Signed-off-by: Rander Wang <rander.wang@linux.intel.com>

RanderWang · 2018-10-17T08:46:24Z

update my patch, thanks for review

lgirdwood · 2018-10-18T16:19:45Z

@RanderWang please see 89bef7a. I've had to fix , can you test.

This patch adds a limit on the number of skbs that fuzzers can queue into loopback_queue. 1000 packets for rose loopback seems more than enough. Then, since we now have multiple cpus in most linux hosts, we also need to limit the number of skbs rose_loopback_timer() can dequeue at each round. rose_loopback_queue() can be drop-monitor friendly, calling consume_skb() or kfree_skb() appropriately. Finally, use mod_timer() instead of del_timer() + add_timer() syzbot report was : rcu: INFO: rcu_preempt self-detected stall on CPU rcu: 0-...!: (10499 ticks this GP) idle=536/1/0x4000000000000002 softirq=103291/103291 fqs=34 rcu: (t=10500 jiffies g=140321 q=323) rcu: rcu_preempt kthread starved for 10426 jiffies! g140321 f0x0 RCU_GP_WAIT_FQS(5) ->state=0x402 ->cpu=1 rcu: RCU grace-period kthread stack dump: rcu_preempt I29168 10 2 0x80000000 Call Trace: context_switch kernel/sched/core.c:2877 [inline] __schedule+0x813/0x1cc0 kernel/sched/core.c:3518 schedule+0x92/0x180 kernel/sched/core.c:3562 schedule_timeout+0x4db/0xfd0 kernel/time/timer.c:1803 rcu_gp_fqs_loop kernel/rcu/tree.c:1971 [inline] rcu_gp_kthread+0x962/0x17b0 kernel/rcu/tree.c:2128 kthread+0x357/0x430 kernel/kthread.c:253 ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:352 NMI backtrace for cpu 0 CPU: 0 PID: 7632 Comm: kworker/0:4 Not tainted 5.1.0-rc5+ thesofproject#172 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Workqueue: events iterate_cleanup_work Call Trace: <IRQ> __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x172/0x1f0 lib/dump_stack.c:113 nmi_cpu_backtrace.cold+0x63/0xa4 lib/nmi_backtrace.c:101 nmi_trigger_cpumask_backtrace+0x1be/0x236 lib/nmi_backtrace.c:62 arch_trigger_cpumask_backtrace+0x14/0x20 arch/x86/kernel/apic/hw_nmi.c:38 trigger_single_cpu_backtrace include/linux/nmi.h:164 [inline] rcu_dump_cpu_stacks+0x183/0x1cf kernel/rcu/tree.c:1223 print_cpu_stall kernel/rcu/tree.c:1360 [inline] check_cpu_stall kernel/rcu/tree.c:1434 [inline] rcu_pending kernel/rcu/tree.c:3103 [inline] rcu_sched_clock_irq.cold+0x500/0xa4a kernel/rcu/tree.c:2544 update_process_times+0x32/0x80 kernel/time/timer.c:1635 tick_sched_handle+0xa2/0x190 kernel/time/tick-sched.c:161 tick_sched_timer+0x47/0x130 kernel/time/tick-sched.c:1271 __run_hrtimer kernel/time/hrtimer.c:1389 [inline] __hrtimer_run_queues+0x33e/0xde0 kernel/time/hrtimer.c:1451 hrtimer_interrupt+0x314/0x770 kernel/time/hrtimer.c:1509 local_apic_timer_interrupt arch/x86/kernel/apic/apic.c:1035 [inline] smp_apic_timer_interrupt+0x120/0x570 arch/x86/kernel/apic/apic.c:1060 apic_timer_interrupt+0xf/0x20 arch/x86/entry/entry_64.S:807 RIP: 0010:__sanitizer_cov_trace_pc+0x0/0x50 kernel/kcov.c:95 Code: 89 25 b4 6e ec 08 41 bc f4 ff ff ff e8 cd 5d ea ff 48 c7 05 9e 6e ec 08 00 00 00 00 e9 a4 e9 ff ff 90 90 90 90 90 90 90 90 90 <55> 48 89 e5 48 8b 75 08 65 48 8b 04 25 00 ee 01 00 65 8b 15 c8 60 RSP: 0018:ffff8880ae807ce0 EFLAGS: 00000286 ORIG_RAX: ffffffffffffff13 RAX: ffff88806fd40640 RBX: dffffc0000000000 RCX: ffffffff863fbc56 RDX: 0000000000000100 RSI: ffffffff863fbc1d RDI: ffff88808cf94228 RBP: ffff8880ae807d10 R08: ffff88806fd40640 R09: ffffed1015d00f8b R10: ffffed1015d00f8a R11: 0000000000000003 R12: ffff88808cf941c0 R13: 00000000fffff034 R14: ffff8882166cd840 R15: 0000000000000000 rose_loopback_timer+0x30d/0x3f0 net/rose/rose_loopback.c:91 call_timer_fn+0x190/0x720 kernel/time/timer.c:1325 expire_timers kernel/time/timer.c:1362 [inline] __run_timers kernel/time/timer.c:1681 [inline] __run_timers kernel/time/timer.c:1649 [inline] run_timer_softirq+0x652/0x1700 kernel/time/timer.c:1694 __do_softirq+0x266/0x95a kernel/softirq.c:293 do_softirq_own_stack+0x2a/0x40 arch/x86/entry/entry_64.S:1027 Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: David S. Miller <davem@davemloft.net>

Samples

lgirdwood requested changes Oct 8, 2018

View reviewed changes

RanderWang force-pushed the whl-hda branch 2 times, most recently from f35f248 to 047d682 Compare October 9, 2018 05:23

RanderWang force-pushed the whl-hda branch from 047d682 to 3217f9f Compare October 17, 2018 08:38

lgirdwood merged commit c250eb3 into thesofproject:topic/sof-dev Oct 17, 2018

emilchudzik mentioned this pull request Oct 23, 2018

[WHL] HDA - huge distortion during playback and capture #202

Closed

aiChaoSONG pushed a commit to aiChaoSONG/linux that referenced this pull request May 6, 2021

Merge pull request thesofproject#172 from ojeda/samples

7ed5aa1

Samples

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ASOC: SOF: add a workaround to detect HDA HDMI codecs#172

ASOC: SOF: add a workaround to detect HDA HDMI codecs#172
lgirdwood merged 1 commit intothesofproject:topic/sof-devfrom
RanderWang:whl-hda

RanderWang commented Sep 30, 2018 •

edited

Loading

Uh oh!

RanderWang commented Sep 30, 2018

Uh oh!

keyonjie commented Oct 8, 2018

Uh oh!

RanderWang commented Oct 8, 2018

Uh oh!

lgirdwood Oct 8, 2018

Uh oh!

RanderWang Oct 9, 2018

Uh oh!

lgirdwood Oct 15, 2018

Uh oh!

RanderWang commented Oct 9, 2018

Uh oh!

RanderWang commented Oct 15, 2018

Uh oh!

RanderWang commented Oct 17, 2018

Uh oh!

lgirdwood commented Oct 18, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

RanderWang commented Sep 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RanderWang commented Sep 30, 2018

Uh oh!

keyonjie commented Oct 8, 2018

Uh oh!

RanderWang commented Oct 8, 2018

Uh oh!

lgirdwood Oct 8, 2018

Choose a reason for hiding this comment

Uh oh!

RanderWang Oct 9, 2018

Choose a reason for hiding this comment

Uh oh!

lgirdwood Oct 15, 2018

Choose a reason for hiding this comment

Uh oh!

RanderWang commented Oct 9, 2018

Uh oh!

RanderWang commented Oct 15, 2018

Uh oh!

RanderWang commented Oct 17, 2018

Uh oh!

lgirdwood commented Oct 18, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

RanderWang commented Sep 30, 2018 •

edited

Loading