ASoC: amd: acp-config: Enable SOF audio for Google chrome boards.#3205
ASoC: amd: acp-config: Enable SOF audio for Google chrome boards.#3205kv2019i merged 1 commit intothesofproject:topic/sof-devfrom
Conversation
ajitkupandey
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
| }, | ||
| { | ||
| .flags = FLAG_AMD_SOF, | ||
| .device = ACP_PCI_DEV_ID, |
There was a problem hiding this comment.
just to confirm, this would switch existing solutions for this PCI ID 0x15E2 to SOF. Is this intentional?
amd/mach-config.h:#define ACP_PCI_DEV_ID 0x15E2
amd/renoir/rn_acp3x.h:#define ACP_DEVICE_ID 0x15E2
amd/vangogh/acp5x.h:#define ACP_DEVICE_ID 0x15E2
There was a problem hiding this comment.
This would not switch as these solutions are for non-chrome platforms and we have a DMI_CHECK for vendor to update flags. We are also planning to add additional checks in pci_probe of these solutions to avoid conflicts with same pci_id.
There was a problem hiding this comment.
We are also planning to add additional checks in pci_probe of these solutions to avoid conflicts with same pci_id.
Why not do it in the common module called by each pci_probe? That was the recommended solution from Takashi and Jaroslav.
There was a problem hiding this comment.
we don't have a options currently but we are in process of developing a common framework to avoid such conflicts in future. It will take some time for us to implement but for now i'll add pci->revision check in this module so that it won't conflict with older platforms.
We need to support sof audio on different variants of Google boards. Add new entry in dmi table to enable SOF flag on Google chrome boards. Also add newer machines to sof_machines list with codecs and amps acpi id check to register sof sound cards on different variants. Signed-off-by: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
|
@ajitkupandey can you rebase and remove the merge commit please? |
ajitkupandey
force-pushed
the
configpush
branch
from
d80cf9d to
96d7962
Compare
3 participants
We need to support sof audio on different variants of Google boards.
Add new entry in dmi table to enable SOF flag on Google chrome boards.
Also add newer machines to sof_machines list with codecs and amps acpi
id check to register sof sound cards on different variants.
Signed-off-by: Ajit Kumar Pandey AjitKumar.Pandey@amd.com