Skip to content

ASoC: SOF: mediatek: Revise mt8195 boot flow#3450

Merged
plbossart merged 2 commits intothesofproject:topic/sof-devfrom
yaochunhung:mt8195-fix-altresetvec
Jul 5, 2022
Merged

ASoC: SOF: mediatek: Revise mt8195 boot flow#3450
plbossart merged 2 commits intothesofproject:topic/sof-devfrom
yaochunhung:mt8195-fix-altresetvec

Conversation

@yaochunhung
Copy link
Copy Markdown

Hi,
This patch will fix statVectorSel wrong setting and modify shutdown flow to pull dsp runstall high before reset dsp to avoid unexpected error.
Pleas help to review it. Thanks.

@yaochunhung
Copy link
Copy Markdown
Author

SOFCI TEST

Copy link
Copy Markdown
Collaborator

@ujfalusi ujfalusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaochunhung, I would separate the patch to a fix (STATVECTOR_SEL correction) and the rest.

Comment thread sound/soc/sof/mediatek/mt8195/mt8195-loader.c
1. Revise hifixdsp shutdown flow to pull runstall high then reset high.
2. Add 1 us delay between D/BRESET high and low for 10 DSP cycles(26M)
   based on IP vendor's suggestion.

Signed-off-by: YC Hung <yc.hung@mediatek.com>
@yaochunhung yaochunhung force-pushed the mt8195-fix-altresetvec branch from c8e099f to 410aa86 Compare March 10, 2022 03:50
@yaochunhung
Copy link
Copy Markdown
Author

SOFCI TEST

@yaochunhung
Copy link
Copy Markdown
Author

Hi all,
Could someone help to point out what happens for this test failure? I wonder why this PR cause this failure. Thanks.

@bardliao
Copy link
Copy Markdown
Collaborator

Hi all, Could someone help to point out what happens for this test failure? I wonder why this PR cause this failure. Thanks.

The check-suspend-resume-with-playback-5.sh and check-suspend-resume-with-capture-5.sh failures of TGLU_RVP_SDW is a known issue #3459

Fix StatVectorSel wrong setting.

Fixes: 0ee31f3(ASoC: SOF: mediatek: Add fw loader and mt8195 dsp
       ops to load firmware)
Signed-off-by: YC Hung <yc.hung@mediatek.com>
@yaochunhung yaochunhung force-pushed the mt8195-fix-altresetvec branch from 410aa86 to bbcfbec Compare March 14, 2022 01:49
@yaochunhung yaochunhung requested a review from ujfalusi March 30, 2022 07:06
@yaochunhung
Copy link
Copy Markdown
Author

Can someone help to review this PR? Thanks a lot.

@plbossart
Copy link
Copy Markdown
Member

@ujfalusi you good with this PR?

@yaochunhung
Copy link
Copy Markdown
Author

@ujfalusi Could you please help to review this PR? Thanks.

@plbossart
Copy link
Copy Markdown
Member

@ujfalusi ping. You were the only reviewer requesting changes.

@kuanhsuncheng
Copy link
Copy Markdown

kuanhsuncheng commented Jun 30, 2022

Hi, Everyone, are we all good with this PR?

@plbossart plbossart merged commit d6f8b80 into thesofproject:topic/sof-dev Jul 5, 2022
oder-chiou pushed a commit to oder-chiou/linux-soundwire that referenced this pull request May 5, 2026
….org/drm/drm-intel into drm-next

UAPI Changes:
- Add reworked uAPI for DG1 behind CONFIG_BROKEN (Matt A, Abdiel)

Driver Changes:

- Fix for Gitlab issues thesofproject#3293 and thesofproject#3450:
  Avoid kernel crash on older L-shape memory machines

- Add Wa_14010733141 (VDBox SFC reset) for Gen11+ (Aditya)
- Fix crash in auto_retire active retire callback due to
  misalignment (Stephane)
- Fix overlay active retire callback alignment (Tvrtko)
- Eliminate need to align active retire callbacks (Matt A, Ville,
  Daniel)
- Program FF_MODE2 tuning value for all Gen12 platforms (Caz)
- Add Wa_14011060649 for TGL,RKL,DG1 and ADLS (Swathi)
- Create stolen memory region from local memory on DG1 (CQ)
- Place PD in LMEM on dGFX (Matt A)
- Use WC when default state object is allocated in LMEM (Venkata)
- Determine the coherent map type based on object location (Venkata)
- Use lmem physical addresses for fb_mmap() on discrete (Mohammed)
- Bypass aperture on fbdev when LMEM is available (Anusha)
- Return error value when displayable BO not in LMEM for dGFX (Mohammed)
- Do release kernel context if breadcrumb measure fails (Janusz)
- Hide modparams for compiled-out features (Tvrtko)
- Apply Wa_22010271021 for all Gen11 platforms (Caz)
- Fix unlikely ref count race in arming the watchdog timer (Tvrtko)
- Check actual RC6 enable status in PMU (Tvrtko)
- Fix a double free in gen8_preallocate_top_level_pdp (Lv)
- Use trylock in shrinker for GGTT on BSW VT-d and BXT (Maarten)
- Remove erroneous i915_is_ggtt check for
  I915_GEM_OBJECT_UNBIND_VM_TRYLOCK (Maarten)

- Convert uAPI headers to real kerneldoc (Matt A)
- Clean up kerneldoc warnings headers (Matt A, Maarten)
- Fail driver if LMEM training failed (Matt R)
- Avoid div-by-zero on Gen2 (Ville)
- Read C0DRB3/C1DRB3 as 16 bits again and add _BW suffix (Ville)
- Remove reference to struct drm_device.pdev (Thomas)
- Increase separation between GuC and execlists code (Chris, Matt B)

- Use might_alloc() (Bernard)
- Split DGFX_FEATURES from GEN12_FEATURES (Lucas)
- Deduplicate Wa_22010271021 programming on (Jose)
- Drop duplicate WaDisable4x2SubspanOptimization:hsw (Tvrtko)
- Selftest improvements (Chris, Hsin-Yi, Tvrtko)
- Shuffle around init_memory_region for stolen (Matt)
- Typo fixes (wengjianfeng)

[airlied: fix conflict with fixes in i915_active.c]
Signed-off-by: Dave Airlie <airlied@redhat.com>

From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/YLCbBR22BsQ/dpJB@jlahtine-mobl.ger.corp.intel.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants