Revert "ASoC: SOF: Intel: MTL: Enable DMI L1"#4238
Merged
ujfalusi merged 1 commit intothesofproject:topic/sof-devfrom Mar 13, 2023
Merged
Revert "ASoC: SOF: Intel: MTL: Enable DMI L1"#4238ujfalusi merged 1 commit intothesofproject:topic/sof-devfrom
ujfalusi merged 1 commit intothesofproject:topic/sof-devfrom
Conversation
This reverts commit 04f818c. It came to our attention that the access to the EM2 register is restricted to the DSP side on MTL compared to prior platforms. Writing to it from the host side has no effect (negative or positive), it is better to remove the code to not cause confusion and wrong impression. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
requested review from
ajitkupandey,
bardliao,
dbaluta,
kuanhsuncheng,
kv2019i,
lgirdwood,
plbossart,
ranj063 and
yaochunhung
as code owners
Collaborator
Author
|
Same revert sent upstream: https://lore.kernel.org/alsa-devel/20230310133454.15362-1-peter.ujfalusi@linux.intel.com/ |
plbossart
approved these changes
Mar 10, 2023
ranj063
approved these changes
Mar 10, 2023
Collaborator
Author
|
Not a single commit can be 'rebase and merge'??? |
1 similar comment
Collaborator
Author
|
Not a single commit can be 'rebase and merge'??? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 04f818c.
It came to our attention that the access to the EM2 register is restricted to the DSP side on MTL compared to prior platforms.
Writing to it from the host side has no effect (negative or positive), it is better to remove the code to not cause confusion and wrong impression.