ASoC: SOF: Intel: hda: Do not probe Soundwire in nocodec mode#5324
Conversation
Soundwire is not needed for nocodec mode, skip probing it. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
lyakh
left a comment
lyakh
left a comment
There was a problem hiding this comment.
this fixes a problem with a specific real-life device configuration, where SDW wasn't needed but still it was preventing the device from being used in nocodec mode
| if (IS_ENABLED(CONFIG_SND_SOC_SOF_NOCODEC_DEBUG_SUPPORT) && | ||
| sof_debug_check_flag(SOF_DBG_FORCE_NOCODEC)) | ||
| goto skip_soundwire; | ||
|
|
There was a problem hiding this comment.
"SoundWire is not needed" but does it help to actually remove the scan?
I don't recall what "nocodec" means but we certainly have cases where we don't have actual SoundWire codecs connected. Is this the case that nocodec really means SSP/DMIC only?
There was a problem hiding this comment.
Yes, nocodec is SSP+DMIC. We need HDA for host DMA (and for Link with ACE2+).
What @lyakh faced is that a device which fails to probe with SDW cannot be turned to nocodec due to the fact that SDW fails. This should not prevent nocodec as it is irrelevant.
I don't know the details, but I think it is due to misconfiguration of ACPI table for SDW versus reality.
Yes, this happens in development environment, so things are moving here and there and the nocodec is a developer configuration.
6 participants
Soundwire is not needed for nocodec mode, skip probing it.