ASoC: Intel: Use proper namespace identifiers#5410
Closed
naveen-manohar wants to merge 3 commits intothesofproject:topic/sof-devfrom
Closed
ASoC: Intel: Use proper namespace identifiers#5410naveen-manohar wants to merge 3 commits intothesofproject:topic/sof-devfrom
naveen-manohar wants to merge 3 commits intothesofproject:topic/sof-devfrom
Conversation
naveen-manohar
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart,
ranj063 and
ujfalusi
as code owners
naveen-manohar
force-pushed
the
ns-correction
branch
2 times, most recently
from
9972470 to
ada1c36
Compare
ujfalusi
requested changes
May 9, 2025
| h2link->mic_privacy_mask = mask; | ||
| } | ||
| EXPORT_SYMBOL_NS(hdac_bus_eml_set_mic_privacy_mask, "SND_SOC_SOF_HDA_MLINK"); | ||
| EXPORT_SYMBOL_NS(hdac_bus_eml_set_mic_privacy_mask, SND_SOC_SOF_HDA_MLINK); |
Collaborator
There was a problem hiding this comment.
No, this is not correct, see:
cdd30eb ("module: Convert symbol namespace to string literal")
Collaborator
There was a problem hiding this comment.
@naveen-manohar This is only for your 6.12 kernel, not for topic/sof-dev branch
Author
There was a problem hiding this comment.
@ujfalusi Thanks for the info.
As the build fails on v6.12, for now i have posted a DONOT_MERGE series
…pers for SoundWire BPT DMA Patch Applicable only on v6.12 'EXPORT_SYMBOL_NS' expects namespace identifier directly, not as a string literal. Patch Fixes: ERROR: modpost: module snd-sof-intel-hda-sdw-bpt uses symbol hdac_bus_eml_sdw_map_stream_ch from namespace SND_SOC_SOF_HDA_MLINK, but does not import it. ERROR: modpost: module snd-sof-intel-hda-sdw-bpt uses symbol hda_cl_prepare from namespace SND_SOC_SOF_INTEL_HDA_COMMON, but does not import it. ERROR: modpost: module snd-sof-intel-hda-sdw-bpt uses symbol hdac_bus_eml_sdw_get_hlink from namespace SND_SOC_SOF_HDA_MLINK, but does not import it. ERROR: modpost: module snd-sof-intel-hda-sdw-bpt uses symbol hda_cl_cleanup from namespace SND_SOC_SOF_INTEL_HDA_COMMON, but does not import it. ERROR: modpost: module snd-sof-intel-hda-sdw-bpt uses symbol hda_cl_trigger from namespace SND_SOC_SOF_INTEL_HDA_COMMON, but does not import it. ERROR: modpost: module snd-sof-intel-hda-sdw-bpt uses symbol hda_dsp_stream_get_position from namespace SND_SOC_SOF_INTEL_HDA_COMMON, but does not import it. Patch updates macro calls in `sound/soc/sof/intel/da-sdw-bpt.c` Fixes: 5d5cb86 ("ASoC: SOF: Intel: hda-sdw-bpt: add helpers for SoundWire BPT DMA") Suggested-by: Bard Liao <yung-chuan.liao@linux.intel.com> Signed-off-by: Naveen Manohar <naveen.m@intel.com>
…rt for mic privacy in VS SHIM registers Patch Applicable only on v6.12 'EXPORT_SYMBOL_NS' expects namespace identifier directly, not as a string literal. Patch Fixes: sound/soc/sof/intel/snd-sof-intel-hda-mlink.mod.c:49:55: error: expected ')' Patch updates macro calls in `sound/soc/sof/intel/hda-mlink.c` Fixes: 0978e82 ("ASoC: SOF: Intel: hda-mlink: Add support for mic privacy in VS SHIM registers") Signed-off-by: Naveen Manohar <naveen.m@intel.com>
…s setup code Patch Applicable only on v6.12 'EXPORT_SYMBOL_NS' expects namespace identifier directly, not as a string literal. Patch Fixes: sound/soc/sof/intel/snd-sof-pci-intel-mtl.mod.c:34:37: error: expected ')' Patch updates macro calls in `sound/soc/sof/intel/mtl.c` Fixes: 6982333 ("ASoC: SOF: Intel: mtl: Split up dsp_ops setup code") Signed-off-by: Naveen Manohar <naveen.m@intel.com>
naveen-manohar
force-pushed
the
ns-correction
branch
2 times, most recently
from
06b42dc to
dd34212
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'EXPORT_SYMBOL_NS' expects namespace identifier directly, not as a string literal. Patch updates macro calls in
sound/soc/sof/intel/hda-mlink.csound/soc/sof/intel/hda-sdw-bpt.csound/soc/sof/intel/mtl.cSuggested-by: Bard Liao yung-chuan.liao@linux.intel.com