[NOT FOR UPSTREAM] ASoC: SOF: ipc4-mtrace: Fix NULL dereference on reboot caused by not for upstream patch#5505
Merged
ujfalusi merged 2 commits intothesofproject:topic/sof-devfrom Aug 12, 2025
Conversation
… ipc4_mtrace_free()" This reverts commit e551714. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
…guration Allow re-initialization of private data of mtrace without module removal. This can only happen with the non upstream debug interface. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart and
ranj063
as code owners
singalsu
approved these changes
Aug 7, 2025
Collaborator
singalsu
left a comment
singalsu
left a comment
There was a problem hiding this comment.
This fixes the shutdown panic issue, thanks Peter!
kv2019i
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
on reboot/shutdown the kernel crashes since the mtrace private data is freed up.
Revert that patch and replace it with a one which re-initializes the mtrace private data on consequent init in case the debug ops test is in use.