tools: tplgtool2: Fix array size calculation for enum values #1230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-hb
reviewed
Sep 7, 2024
marc-hb
reviewed
Sep 9, 2024
Collaborator
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
BTW I'm really curious what construct was doing with this float... if not converting it to an int then what else? This sounds like a bug in construct, it should probably provide a better message
singalsu
approved these changes
Sep 9, 2024
Contributor
singalsu
left a comment
singalsu
left a comment
There was a problem hiding this comment.
Checked to fix the issue, thanks!
Compute the max name length in terms of number of int32's and use that set the values array size for parsing the enum controls properly. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ranj063
force-pushed
the
fix/enum_control
branch
from
8a24122 to
6fe1b92
Compare
marc-hb
approved these changes
Sep 9, 2024
Collaborator
|
Usual LNL failures in https://sof-ci.01.org/softestpr/PR1230/build738/devicetest/index.html, everything else green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the computed value to integer to set the values array size for parsing the enum controls properly.