test: test-mic-privacy: fix skipping test #1316
Conversation
arikgreen
requested review from
a team,
golowanow,
lgirdwood and
marc-hb
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR fixes test skipping logic in the mic privacy test script by improving hardware dependency checks and adding configurable DSP settle time. The changes enhance test reliability by properly detecting when required hardware (usbrelay) is unavailable.
- Improved usbrelay availability checking with better error handling
- Added configurable DSP settle time parameter with 2-second default
- Reorganized test setup logic for better flow
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arikgreen
force-pushed
the
test-mic-privacy-fix-skip
branch
from
e33f50b to
f400925
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arikgreen
force-pushed
the
test-mic-privacy-fix-skip
branch
from
f400925 to
e0936d9
Compare
arikgreen
force-pushed
the
test-mic-privacy-fix-skip
branch
from
e0936d9 to
63bd62e
Compare
arikgreen
force-pushed
the
test-mic-privacy-fix-skip
branch
from
63bd62e to
53b5c61
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arikgreen
requested review from
majunkier
and removed request for
SzymonRichert
arikgreen
force-pushed
the
test-mic-privacy-fix-skip
branch
from
48e58f3 to
55b6952
Compare
arikgreen
force-pushed
the
test-mic-privacy-fix-skip
branch
from
55b6952 to
2d1ee32
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| dlogi "Checking usbrelay availability..." | ||
| command -v usbrelay || { | ||
| # If usbrelay package is not installed | ||
| skip_test "usbrelay command not found." | ||
| } | ||
|
|
||
| # display current status of relays | ||
| usbrelay_switch --debug || { | ||
| skip_test "Failed to initialize usbrelay hardware." | ||
| } |
There was a problem hiding this comment.
The usbrelay availability check on line 156 only verifies the command exists but doesn't capture or suppress its output. When the command succeeds, any output will be displayed before the skip_test on failure. Consider redirecting output: command -v usbrelay > /dev/null || { ... }
arikgreen
force-pushed
the
test-mic-privacy-fix-skip
branch
from
2d1ee32 to
a1fb70d
Compare
Fix skip if no module named: usbrelay. Add skip if no relays hardware are detected. Add the new parameter to test: relay-settle-sleep by default = 1s Add loop to run more then 1 iteration. Signed-off-by: Artur Wilczak <arturx.wilczak@intel.com>
arikgreen
force-pushed
the
test-mic-privacy-fix-skip
branch
from
a1fb70d to
3ca571c
Compare
4 participants
Fix skip if no module named: usbrelay.
Add skip if no relays hardware are detected.
Add the new parameter to test:
dsp-settle-sleep by default = 2s