kernel-log-check: filter i915 supsending crtc logs#738
Merged
XiaoyunWu6666 merged 1 commit intothesofproject:mainfrom Jul 19, 2021
Merged
kernel-log-check: filter i915 supsending crtc logs#738XiaoyunWu6666 merged 1 commit intothesofproject:mainfrom
XiaoyunWu6666 merged 1 commit intothesofproject:mainfrom
Conversation
fredoh9
reviewed
Jul 14, 2021
| # i915 crtc logs can be ignored | ||
| # origin logs seen on EHL_RVP_I2S platforms | ||
| # i915 0000:00:02.0: [drm] *ERROR* Suspending crtc's failed with -22 | ||
| ignore_str="$ignore_str"'|i915 [[:digit:].:]+: \[drm\] \*ERROR\* Suspending .+' |
Contributor
There was a problem hiding this comment.
Instead '.+' just specify the rest of the log, "crtc's failed with".
We don't want random matching unless there are some error patterns.
Collaborator
Not every i915 error is irrelevant to audio, all display connectors carry audio. I would like @kv2019i to confirm this one. |
XiaoyunWu6666
force-pushed
the
filter_i915
branch
from
6c912be to
c4e6b68
Compare
Signed-off-by: Iris Wu <xiaoyun.wu@intel.com>
fredoh9
approved these changes
Jul 15, 2021
Contributor
There was a problem hiding this comment.
Looks good, Thanks!
@XiaoyunWu6666 for next time, please add description to commit message as well. I see good description in github description but the commit message is empty.
Collaborator
|
Here's an example of a display problem impossible to ignore: thesofproject/linux#3042 |
Contributor
|
Out last week, but this seems fine (especially when limited to ehl platform). |
marc-hb
added
area:non-audio Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on EHL platforms , when check suspend resume , 'kernel: i915 0000:00:02.0: [drm] ERROR Suspending crtc's failed with -22' error happens and leads testcase to fail .
Since this is irrelevant to audio , filter it so that the testcase can run successfully
Signed-off-by: Iris Wu xiaoyun.wu@intel.com