Skip to content

[BUG]Why do I need to enable CONFIG_CAVS_TIMER? #4046

@hongshui3000

Description

@hongshui3000

Describe the bug
This code will prevent all xtensa architecture processors from using sof (zephyr), except for the Intel CAVS platform.I don’t understand the necessity of doing so.

file:modules\audio\sof\src\schedule\timer_domain.c

/*
 * Currently the Zephyr clock rate is part it's Kconfig known at build time.
 * SOF on Intel CAVS platforms currently only aligns with Zephyr when both
 * use the CAVS 19.2 MHz SSP clock. TODO - needs runtime alignment.
 */
#if CONFIG_XTENSA && !CONFIG_CAVS_TIMER
#error "Zephyr uses 19.2MHz clock derived from SSP which must be enabled."
#endif

Can it be changed to the following?

#if CONFIG_XTENSA && !CONFIG_CAVS_TIMER && (CONFIG_SOC_SERIES_INTEL_CAVS_V25 || CONFIG_SOC_SERIES_INTEL_CAVS_V20 || CONFIG_SOC_SERIES_INTEL_CAVS_V18 || CONFIG_SOC_SERIES_INTEL_CAVS_V15)
#error "Zephyr uses 19.2MHz clock derived from SSP which must be enabled."
#endif

Metadata

Metadata

Assignees

Labels

bugSomething isn't working as expected

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions