-
Notifications
You must be signed in to change notification settings - Fork 349
Audio: SRC: Add conversions from 8 - 192 kHz to 64 kHz #10130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio: SRC: Add conversions from 8 - 192 kHz to 64 kHz #10130
Conversation
If a non-supported conversion is requested the sizes to allocate and copy are zero. This addition prints a more descriptive error for the situation. Without this change the next null check printed more confusing error "failed to allocate coefficients". Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch adds to coefficients generator script sof_src_ipc4.m the conversions for 8 - 192 kHz to 64 kHz rate. It has been missing previously. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This patch adds the header files with coefficients for supported new rate conversions from 8 - 192 kHz to 64 kHz. Only the headers with changed coefficients values are included. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
|
@lgirdwood I added new coefficients into the latest push. To minimize the changes I had to use another computer to generate with Matlab the coefficients since they were previously generated with it. With Octave with other FIR tool in practice all coefficients would have changed. |
|
Test results for new conversions with testbench and I'll change this to non-draft. |
golowanow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change resolves a problem we've observed at 64 kHz rate set on a PCM
|
SOFCI TEST |
Excellent, thanks for testing it! |
No description provided.