Tools: Topology: Add to nocodec port2 24 kHz rate capability#10234
Draft
singalsu wants to merge 1 commit intothesofproject:mainfrom
Draft
Tools: Topology: Add to nocodec port2 24 kHz rate capability#10234singalsu wants to merge 1 commit intothesofproject:mainfrom
singalsu wants to merge 1 commit intothesofproject:mainfrom
Conversation
This patch adds the 24 kHz rate to PCM capabilities. The 24 kHz rate is defined in the MPEG-2 standard. This also needs a patch to alsa-lib to build the topology without error. The added rate_min/rate_max is not mandatory but it narrows down the range of rates evaluated in alsa-lib in snd_pcm_hw_refine(). Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Collaborator
Author
|
From Jenkins build log here, need the alsa-lib patch: |
lgirdwood
reviewed
Sep 12, 2025
Member
lgirdwood
left a comment
There was a problem hiding this comment.
LGTM, I guess you will make non draft when ALSA part is resolved.
Collaborator
Author
Yep, this simple add only enables tplg build, the aplay - alsa-lib - kernel runtime issue still remains: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds the 24 kHz rate to PCM capabilities. The 24 kHz rate is defined in the MPEG-2 standard. This also needs a patch to alsa-lib to build the topology without error.
The added rate_min/rate_max is not mandatory but it narrows down the range of rates evaluated in alsa-lib in snd_pcm_hw_refine().