-
Notifications
You must be signed in to change notification settings - Fork 349
ptl: reduce the size of the shared buffer on ACE 3.0 #10447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR reduces the shared buffer heap size for the ACE 3.0 (PTL - Panther Lake) platform from 104KB (0x1A000) to 64KB (0x10000) to address out-of-memory issues in CI nocodec tests. Since shared memory isn't widely used yet, this reduction is a practical short-term fix. The change effectively reallocates 40KB from the shared buffer heap to the main heap, as the total heap size (0xD0000 = 848KB) remains constant and the main heap size is calculated as HEAPMEM_SIZE - SHARED_BUFFER_HEAP_MEM_SIZE.
- Reduces shared buffer heap size for ACE 3.0 from 0x1A000 (104KB) to 0x10000 (64KB)
- Addresses memory constraints in CI nocodec tests on PTL platform
- Maintains total heap size while reallocating memory between main and shared heaps
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| default 0x0 if !SOF_USERSPACE_USE_SHARED_HEAP | ||
| default 0x1E000 if SOC_INTEL_ACE15_MTPM || SOC_INTEL_ACE20_LNL | ||
| default 0x1A000 if SOC_INTEL_ACE30 | ||
| default 0x10000 if SOC_INTEL_ACE30 |
Copilot
AI
Dec 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR title contains a typo: "bugger" should be "buffer". While the code change is correct, the PR title should read "ptl: reduce the size of the shared buffer on ACE 3.0" to accurately describe the change being made to SOF_ZEPHYR_SHARED_BUFFER_HEAP_SIZE.
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will merge the next version with spell fix.
CI nocodec tests on PTL are running out of memory since shared memory has been introduced. Since it isn't widely used yet, reduce its default size on ACE 3.0. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lgirdwood let's wait to see that it also fixes the problem in CI - not only in my local test |
and yes, fixed |
kv2019i
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Seems to fix the nocodec tests, now enough memory to run the nocodec test cases.
CI nocodec tests on PTL are running out of memory since shared memory has been introduced. Since it isn't widely used yet, reduce its default size on ACE 3.0.