Skip to content

Conversation

@lyakh
Copy link
Collaborator

@lyakh lyakh commented Dec 16, 2025

CI nocodec tests on PTL are running out of memory since shared memory has been introduced. Since it isn't widely used yet, reduce its default size on ACE 3.0.

Copilot AI review requested due to automatic review settings December 16, 2025 13:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces the shared buffer heap size for the ACE 3.0 (PTL - Panther Lake) platform from 104KB (0x1A000) to 64KB (0x10000) to address out-of-memory issues in CI nocodec tests. Since shared memory isn't widely used yet, this reduction is a practical short-term fix. The change effectively reallocates 40KB from the shared buffer heap to the main heap, as the total heap size (0xD0000 = 848KB) remains constant and the main heap size is calculated as HEAPMEM_SIZE - SHARED_BUFFER_HEAP_MEM_SIZE.

  • Reduces shared buffer heap size for ACE 3.0 from 0x1A000 (104KB) to 0x10000 (64KB)
  • Addresses memory constraints in CI nocodec tests on PTL platform
  • Maintains total heap size while reallocating memory between main and shared heaps

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

default 0x0 if !SOF_USERSPACE_USE_SHARED_HEAP
default 0x1E000 if SOC_INTEL_ACE15_MTPM || SOC_INTEL_ACE20_LNL
default 0x1A000 if SOC_INTEL_ACE30
default 0x10000 if SOC_INTEL_ACE30
Copy link

Copilot AI Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title contains a typo: "bugger" should be "buffer". While the code change is correct, the PR title should read "ptl: reduce the size of the shared buffer on ACE 3.0" to accurately describe the change being made to SOF_ZEPHYR_SHARED_BUFFER_HEAP_SIZE.

Copilot uses AI. Check for mistakes.
@lgirdwood lgirdwood changed the title ptl: reduce the size of the shared bugger on ACE 3.0 ptl: reduce the size of the shared buffer on ACE 3.0 Dec 16, 2025
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge the next version with spell fix.

CI nocodec tests on PTL are running out of memory since shared
memory has been introduced. Since it isn't widely used yet, reduce
its default size on ACE 3.0.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh
Copy link
Collaborator Author

lyakh commented Dec 16, 2025

LGTM. Will merge the next version with spell fix.

@lgirdwood let's wait to see that it also fixes the problem in CI - not only in my local test

@lyakh
Copy link
Collaborator Author

lyakh commented Dec 16, 2025

LGTM. Will merge the next version with spell fix.

@lgirdwood let's wait to see that it also fixes the problem in CI - not only in my local test

and yes, fixed

Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Seems to fix the nocodec tests, now enough memory to run the nocodec test cases.

@kv2019i kv2019i merged commit e3ed883 into thesofproject:main Dec 17, 2025
41 of 43 checks passed
@lyakh lyakh deleted the nomem branch December 17, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants