module-adapter: Add NULL check for sink buffer#10522
Merged
lgirdwood merged 1 commit intothesofproject:mainfrom Feb 5, 2026
Merged
module-adapter: Add NULL check for sink buffer#10522lgirdwood merged 1 commit intothesofproject:mainfrom
lgirdwood merged 1 commit intothesofproject:mainfrom
Conversation
dbaluta
reviewed
Feb 5, 2026
tmleman
approved these changes
Feb 5, 2026
Return error if a sink buffer is not present before it is accessed while calculating period size in module_adapter_prepare. This might occur when a pipeline is built incorrectly (without binding) and the sink buffer is not connected to a module. Signed-off-by: Wojciech Jablonski <wojciech.jablonski@intel.com>
lgirdwood
approved these changes
Feb 5, 2026
abonislawski
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a corner case found in a test with incorrect topology. I think it should be fixed.
Return error if a sink buffer is not present before it is accessed while calculating period size in module_adapter_prepare. This might occur when a pipeline is built incorrectly (without binding) and the sink buffer is not connected to a module.