checkpatch: remove and use clang-format instead #10619
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Note: The list of ForEachMacros can be obtained using: | ||
| # | ||
| # git grep -h '^#define [^[:space:]]*FOR_EACH[^[:space:]]*(' include/ \ | ||
| # | sed "s,^#define \([^[:space:]]*FOR_EACH[^[:space:]]*\)(.*$, - '\1'," \ | ||
| # | sort | uniq | ||
| # | ||
| # References: | ||
| # - https://clang.llvm.org/docs/ClangFormatStyleOptions.html | ||
| # | ||
|
Collaborator
There was a problem hiding this comment. @lgirdwood Should we have a link to the Zephyr version as this is including many definitions from it (and we should probably take in updates from Zephyr if they change converntions)? |
||
| # Based on https://github.com/zephyrproject-rtos/zephyr/blob/main/.clang-format | ||
|
|
||
| --- | ||
lgirdwood marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| BasedOnStyle: LLVM | ||
| AlignConsecutiveMacros: AcrossComments | ||
| AllowShortBlocksOnASingleLine: Never | ||
| AllowShortCaseLabelsOnASingleLine: false | ||
| AllowShortEnumsOnASingleLine: false | ||
| AllowShortFunctionsOnASingleLine: None | ||
| AllowShortIfStatementsOnASingleLine: false | ||
| AllowShortLoopsOnASingleLine: false | ||
| AttributeMacros: | ||
| - __aligned | ||
| - __deprecated | ||
| - __packed | ||
| - __printf_like | ||
| - __syscall | ||
| - __syscall_always_inline | ||
| - __subsystem | ||
| BitFieldColonSpacing: After | ||
| BreakBeforeBraces: Linux | ||
| ColumnLimit: 100 | ||
| ConstructorInitializerIndentWidth: 8 | ||
| ContinuationIndentWidth: 8 | ||
| ForEachMacros: | ||
| - 'ARRAY_FOR_EACH' | ||
| - 'ARRAY_FOR_EACH_PTR' | ||
| - 'FOR_EACH' | ||
| - 'FOR_EACH_FIXED_ARG' | ||
| - 'FOR_EACH_IDX' | ||
| - 'FOR_EACH_IDX_FIXED_ARG' | ||
| - 'FOR_EACH_NONEMPTY_TERM' | ||
| - 'FOR_EACH_FIXED_ARG_NONEMPTY_TERM' | ||
| - 'RB_FOR_EACH' | ||
| - 'RB_FOR_EACH_CONTAINER' | ||
| - 'SYS_DLIST_FOR_EACH_CONTAINER' | ||
| - 'SYS_DLIST_FOR_EACH_CONTAINER_SAFE' | ||
| - 'SYS_DLIST_FOR_EACH_NODE' | ||
| - 'SYS_DLIST_FOR_EACH_NODE_SAFE' | ||
| - 'SYS_SEM_LOCK' | ||
| - 'SYS_SFLIST_FOR_EACH_CONTAINER' | ||
| - 'SYS_SFLIST_FOR_EACH_CONTAINER_SAFE' | ||
| - 'SYS_SFLIST_FOR_EACH_NODE' | ||
| - 'SYS_SFLIST_FOR_EACH_NODE_SAFE' | ||
| - 'SYS_SLIST_FOR_EACH_CONTAINER' | ||
| - 'SYS_SLIST_FOR_EACH_CONTAINER_SAFE' | ||
| - 'SYS_SLIST_FOR_EACH_NODE' | ||
| - 'SYS_SLIST_FOR_EACH_NODE_SAFE' | ||
| - '_WAIT_Q_FOR_EACH' | ||
| - '_WAIT_Q_FOR_EACH_SAFE' | ||
| - 'Z_FOR_EACH' | ||
| - 'Z_FOR_EACH_ENGINE' | ||
| - 'Z_FOR_EACH_EXEC' | ||
| - 'Z_FOR_EACH_FIXED_ARG' | ||
| - 'Z_FOR_EACH_FIXED_ARG_EXEC' | ||
| - 'Z_FOR_EACH_IDX' | ||
| - 'Z_FOR_EACH_IDX_EXEC' | ||
| - 'Z_FOR_EACH_IDX_FIXED_ARG' | ||
| - 'Z_FOR_EACH_IDX_FIXED_ARG_EXEC' | ||
| - 'Z_GENLIST_FOR_EACH_CONTAINER' | ||
| - 'Z_GENLIST_FOR_EACH_CONTAINER_SAFE' | ||
| - 'Z_GENLIST_FOR_EACH_NODE' | ||
| - 'Z_GENLIST_FOR_EACH_NODE_SAFE' | ||
| - 'STRUCT_SECTION_FOREACH' | ||
| - 'STRUCT_SECTION_FOREACH_ALTERNATE' | ||
| - 'TYPE_SECTION_FOREACH' | ||
| - 'K_SPINLOCK' | ||
| - 'COAP_RESOURCE_FOREACH' | ||
| - 'COAP_SERVICE_FOREACH' | ||
| - 'COAP_SERVICE_FOREACH_RESOURCE' | ||
| - 'HTTP_RESOURCE_FOREACH' | ||
| - 'HTTP_SERVER_CONTENT_TYPE_FOREACH' | ||
| - 'HTTP_SERVICE_FOREACH' | ||
| - 'HTTP_SERVICE_FOREACH_RESOURCE' | ||
| - 'I3C_BUS_FOR_EACH_I3CDEV' | ||
| - 'I3C_BUS_FOR_EACH_I3CDEV_SAFE' | ||
| - 'I3C_BUS_FOR_EACH_I2CDEV' | ||
| - 'I3C_BUS_FOR_EACH_I2CDEV_SAFE' | ||
| - 'MIN_HEAP_FOREACH' | ||
| IfMacros: | ||
| - 'CHECKIF' | ||
| # Disabled for now, see bug https://github.com/zephyrproject-rtos/zephyr/issues/48520 | ||
| #IncludeBlocks: Regroup | ||
| IncludeCategories: | ||
| - Regex: '^".*\.h"$' | ||
| Priority: 0 | ||
| - Regex: '^<(assert|complex|ctype|errno|fenv|float|inttypes|limits|locale|math|setjmp|signal|stdarg|stdbool|stddef|stdint|stdio|stdlib|string|tgmath|time|wchar|wctype)\.h>$' | ||
| Priority: 1 | ||
| - Regex: '^\<zephyr/.*\.h\>$' | ||
| Priority: 2 | ||
| - Regex: '.*' | ||
| Priority: 3 | ||
| IndentCaseLabels: false | ||
| IndentGotoLabels: false | ||
| IndentWidth: 8 | ||
| InsertBraces: true | ||
| InsertNewlineAtEOF: true | ||
| SpaceBeforeInheritanceColon: False | ||
| SpaceBeforeParens: ControlStatementsExceptControlMacros | ||
| SortIncludes: Never | ||
| UseTab: ForContinuationAndIndentation | ||
| WhitespaceSensitiveMacros: | ||
| - COND_CODE_0 | ||
| - COND_CODE_1 | ||
| - IF_DISABLED | ||
| - IF_ENABLED | ||
| - LISTIFY | ||
| - STRINGIFY | ||
| - Z_STRINGIFY | ||
| - DT_FOREACH_PROP_ELEM_SEP | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,44 +18,6 @@ permissions: | |
| contents: read | ||
|
|
||
| jobs: | ||
| yamllint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,7 +49,6 @@ tools/test/audio/reports/* | |
| tools/test/audio/zeros_in.raw | ||
|
|
||
| __pycache__ | ||
|
|
||
| build*/ | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This clang-format configuration appears to be duplicated verbatim in two places (
.clang-formatandtools/rimage/.clang-format). Keeping identical configs in multiple locations is likely to diverge over time and create inconsistent formatting depending on where clang-format is invoked from. Consider consolidating to a single source of truth (preferably the repo root), or add an explicit comment/guardrail explaining whytools/rimage/needs its own copy and how it should be kept in sync.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, this has now been removed as its from a time when rimage was a git submodule.