Few minor fixes#10779
Merged
Merged
Conversation
icd is NULL by the time rfree(icd) is called, hence rfree(icd) can be removed. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
Fix two switched letters in SOF_IPC4_INVALID_RESOURCE_EVENT_TYPE declaration. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
serhiy-katsyuba-intel
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
pblaszko,
plbossart and
tmleman
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Two small cleanups in the IPC4 code: drop a no-op free on a NULL pointer and correct a typo in an enum identifier.
Changes:
- Remove dead
rfree(icd)call on the allocation-failure path inipc4_add_comp_dev(icd is NULL there). - Rename
SOF_IPC4_INVALID_RESORUCE_EVENT_TYPEtoSOF_IPC4_INVALID_RESOURCE_EVENT_TYPE.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ipc/ipc4/helper.c | Removes redundant rfree(icd) on alloc-failure path. |
| src/include/ipc4/notification.h | Fixes typo in enum constant name (RESORUCE → RESOURCE). |
kv2019i
approved these changes
May 15, 2026
tmleman
approved these changes
May 15, 2026
lyakh
approved these changes
May 15, 2026
lgirdwood
approved these changes
May 15, 2026
abonislawski
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ipc4: remove unnecessary code
icd is NULL by the time rfree(icd) is called, hence rfree(icd) can be removed.
ipc4: fix minor typo
Fix two switched letters in SOF_IPC4_INVALID_RESOURCE_EVENT_TYPE declaration.