platform: refactor: deduplicate code for APL&CNL#121
platform: refactor: deduplicate code for APL&CNL#121lgirdwood merged 2 commits intothesofproject:nextfrom
Conversation
jajanusz
force-pushed
the
platforms-refactor
branch
from
a34c028 to
68f7149
Compare
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Missing a commit message. Can you also do this PR against -next as master is in code freeze (bug fixes only).
|
What do you mean by missing commit message? There are commit messages for each commit and title of PR, do you mean something else? |
|
The commit message is only showing the title and SoB. It should also have a statement saying what is changing and why (especially important for big change sets like this one). |
|
CI observed building failure. Failed Platform: baytrail make[5]: *** No rule to make target '../../platform/baytrail/libplatform.la', needed by 'sof'. Stop. |
|
@jiawang6 |
|
@jajanusz , sorry, CI was blocked by Jenkins CI maintaining at that time. I have manually rerun the updated PR and the result is successful. |
|
@jajanusz this is fine, but lets merge into -next since we are in code freeze on master. You may need to update your PR so I can merge into -next. |
|
@lgirdwood I know, just need some changes to make it mergable to next |
jajanusz
force-pushed
the
platforms-refactor
branch
from
68f7149 to
62528f5
Compare
jajanusz
force-pushed
the
platforms-refactor
branch
from
62528f5 to
a292d45
Compare
First step of deduplicating platforms code. Keeps binaries identical with just removing duplicated code. It is critical for maintainability of platform-specific sources (and adding new platforms in the future). Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Wraps common code into libtool convinence libs, because we don't want to list common source files for each platform with relative paths. Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
|
Rebased and updated for next |
3 participants
First step of deduplicating platforms code.
1st commit keeps binaries identical with just removing duplicated code.
2nd commit wraps common code into libtool convinence libs, because we don't want to list common source files for each platform with relative paths.
Next step will be removing #ifdefs and moving small chunks of platform-specific code to their folders, then deduplicating header files.
It is critical for maintainability of platform-specific sources (and adding new platforms in the future).