Skip to content

Add nocodec pipeline for i.MX8QXP board#1892

Merged
dbaluta merged 6 commits intothesofproject:masterfrom
dbaluta:sof-nocodec
Oct 4, 2019
Merged

Add nocodec pipeline for i.MX8QXP board#1892
dbaluta merged 6 commits intothesofproject:masterfrom
dbaluta:sof-nocodec

Conversation

@dbaluta
Copy link
Copy Markdown
Collaborator

@dbaluta dbaluta commented Oct 1, 2019

i.MX8QXP contains one ESAI0 interface. This patch series adds helper m4 macros for ESAI and creates a simple playback topology with ESAI0 and nocodec.

With this we can test Dummy DMA, EDMA and ESAI drivers.

Corresponding changes for Linux kernel side will be sent right away.

@dbaluta
Copy link
Copy Markdown
Collaborator Author

dbaluta commented Oct 1, 2019

Any idea why do I get this checkpatch.pl warnings:

WARNING: Please update ABI in accordance with http://semver.org
#57: FILE: src/include/ipc/dai-imx.h:31:

I did change the SOF_ABI_MINOR from src/include/kernel/abi.h though?

@lgirdwood lgirdwood added the ABI ABI change involved label Oct 1, 2019
@lgirdwood
Copy link
Copy Markdown
Member

@dbaluta it's just a nag to make sure ABI increments are not forgotten, although it's not clever enough to know you have updated all the time. Feel free to fix.
I have classifed the ABI as minor 11 as per the PR. https://github.com/orgs/thesofproject/projects/2

Copy link
Copy Markdown
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments below

Comment thread tools/topology/platform/common/esai.m4 Outdated
Comment thread src/include/ipc/dai-imx.h Outdated
Comment thread src/include/ipc/dai-imx.h Outdated
@dbaluta dbaluta force-pushed the sof-nocodec branch 3 times, most recently from 112b33a to 0370583 Compare October 2, 2019 14:11
Copy link
Copy Markdown
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more question below

Comment thread tools/topology/CMakeLists.txt Outdated
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Only add ESAI MCLK ID token for now

Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
ESAI is one of the DAIs found on i.MX8 platforms. Introduce esai_params
used to pass configuration from topology via AP to DSP.

Only MCLK and TDM related params for now.

Because this is a new struct, increment only ABI MINOR version
which makes the SOF FW backward compatible with older kernel versions.

Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
i.MX8QXP has one ESAI interface. Create a simple topology
without a codec for playback of 2 channels, 16bits samples
at 48Khz.

Host -> Buffer0 -> Volume -> Buffer1 -> ESAI0

This is useful for testing various components like Dummy DMA,
EDMA and ESAI drivers.

For more information about ESAI you can read i.MX8QXP RM at:
https://www.nxp.com/docs/en/reference-manual/IMX8DQXPRM.pdf

Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
@dbaluta
Copy link
Copy Markdown
Collaborator Author

dbaluta commented Oct 4, 2019

@plbossart ready now! Will push both PRs (FW & kernel) after your review.

Copy link
Copy Markdown
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbaluta dbaluta merged commit 680eb9c into thesofproject:master Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ABI ABI change involved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants