EQ FIR optimize proposal#194
Merged
lgirdwood merged 5 commits intothesofproject:nextfrom Aug 8, 2018
Merged
Conversation
lgirdwood
requested changes
Aug 4, 2018
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Minor comment, can you also change PR to pull into next as master is code freeze.
Collaborator
Author
There was a problem hiding this comment.
I changed the pull request into next from edit menu but there's a lot of other commits and even conflicts in other parts than my work. It looks like next was behind master.
Member
There was a problem hiding this comment.
@singalsu you will need to rebase on top of next, this will remove other commits
This patch add possibility to use two samples per call processed filter core. The use of optimized version depends on FIR core header files settings. Normally when compiled with xt-xcc the optimized filter version will be used. The set data and get data IPC is updated to use binary and enum control commands. A pass-trough copy function is added get working pipeline with non-configured EQ. The full-circular EQ copy function is needed since it is unnecessary. Normal SOF components work with buffers EQ mute is removed since SOF components do not usually support it except volume. The IPC is updated to match ALSA binary and enum controls style. The previous approach was not practical for kernel driver side. Code style is updated the pass the checks. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com> Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
eq_fir_optimize_proposal
branch
from
3c7f7cb to
bb3407c
Compare
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
eq_fir_optimize_proposal
branch
from
bb3407c to
920dc98
Compare
Collaborator
Author
|
@lgirdwood I've now rebased to next and fixed that // comment line. It was a mistake and that header file that I had commented out for some weird reason needs to be included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch optimizes FIR EQ computation speed a lot when compiled with xt-xcc.
The IPC is updated to match ALSA conventions with binary and enum controls.
Also code style is fixed to pass the pre-commit and post-commit checks.