Skip to content

scripts/testbench: add set -e#2934

Merged
lgirdwood merged 1 commit into
thesofproject:masterfrom
marc-hb:testbench-set-e
May 18, 2020
Merged

scripts/testbench: add set -e#2934
lgirdwood merged 1 commit into
thesofproject:masterfrom
marc-hb:testbench-set-e

Conversation

@marc-hb
Copy link
Copy Markdown
Collaborator

@marc-hb marc-hb commented May 13, 2020

Let's stop ignoring build and test failures. Start gradually with the
scripts involved in testbench, more files later.

Follow-up to to bug #2752 "host-testbench.sh ignores errors" and commit
ab42146 ("CI: Travis: enable host testbnech again") and
ab42146~1

Signed-off-by: Marc Herbert marc.herbert@intel.com

@marc-hb
Copy link
Copy Markdown
Collaborator Author

marc-hb commented May 13, 2020

I finally root-caused the SPDX checkpatch warning. It's a very funny checkpatch bug.

WARNING: Misplaced SPDX-License-Identifier tag - use line 1 instead

It happens every time you change line 5 of any script = every time you add something at the top of the script. When you do that, the default git diff -U3 includes context with the SPDX line but misses the shebang, its cuts right between the two.

There's no other checkpatch warning in this PR.

sof-ci/jenkins/pr-device-test has a single, unrelated check-runtime-pm-status.sh failure:

kernel: [  560.168513] sof-audio-pci 0000:00:1f.3: error: cl_dsp_init: timeout HDA_DSP_SRAM_REG_ROM_STATUS read

@marc-hb marc-hb marked this pull request as ready for review May 13, 2020 22:34
@marc-hb marc-hb requested a review from jajanusz as a code owner May 13, 2020 22:34
Copy link
Copy Markdown
Collaborator

@singalsu singalsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the improvements!

Comment thread scripts/host-testbench.sh Outdated
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the same comments as below ' fail on errors'

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done except I changed it to "stop on most errors". For legacy reasons set -e doesn't catch all errors, it catches most of them.

Let's stop ignoring build and test failures. Start gradually with the
scripts involved in testbench, more files later.

Follow-up to to bug thesofproject#2752 "host-testbench.sh ignores errors" and commit
ab42146 ("CI: Travis: enable host testbnech again") and
ab42146~1

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb marc-hb force-pushed the testbench-set-e branch from f035d3c to 1fa7745 Compare May 14, 2020 18:34
@lgirdwood lgirdwood merged commit 19745de into thesofproject:master May 18, 2020
@marc-hb marc-hb deleted the testbench-set-e branch February 12, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants