scripts/testbench: add set -e#2934
Conversation
|
I finally root-caused the SPDX checkpatch warning. It's a very funny checkpatch bug. It happens every time you change line 5 of any script = every time you add something at the top of the script. When you do that, the default There's no other checkpatch warning in this PR.
|
singalsu
left a comment
There was a problem hiding this comment.
Looks good, thanks for the improvements!
There was a problem hiding this comment.
Please add the same comments as below ' fail on errors'
There was a problem hiding this comment.
Done except I changed it to "stop on most errors". For legacy reasons set -e doesn't catch all errors, it catches most of them.
Let's stop ignoring build and test failures. Start gradually with the scripts involved in testbench, more files later. Follow-up to to bug thesofproject#2752 "host-testbench.sh ignores errors" and commit ab42146 ("CI: Travis: enable host testbnech again") and ab42146~1 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Let's stop ignoring build and test failures. Start gradually with the
scripts involved in testbench, more files later.
Follow-up to to bug #2752 "host-testbench.sh ignores errors" and commit
ab42146 ("CI: Travis: enable host testbnech again") and
ab42146~1
Signed-off-by: Marc Herbert marc.herbert@intel.com