test: pipeline_free#319
Merged
lgirdwood merged 1 commit intothesofproject:masterfrom Sep 7, 2018
Merged
Conversation
jajanusz
approved these changes
Sep 6, 2018
Contributor
jajanusz
left a comment
jajanusz
left a comment
There was a problem hiding this comment.
Just one hint in comments for the future.
Good job.
👍
Contributor
There was a problem hiding this comment.
You use setup and teardown for group that is not linked at all - it looks like you reset state in every test.
To show intent and 'scope' of state it would be better to use cmocka_unit_test_setup_teardown in the future for cases like this. Group setup is better for flow when test2 depends on test1 etc.
Added tests for pipeline free and underlining static functions. Also refactored previously added tests to incorporate code reuse. Signed-off-by: Jakub Dabek <jakub.dabek@linux.intel.com>
dabekjakub
force-pushed
the
temp_pipeline_free
branch
from
1a0de29 to
4434ca7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests for pipeline free and underlining static functions.
Also refactored previously added tests to incorporate code reuse.
Signed-off-by: Jakub Dabek jakub.dabek@linux.intel.com