init: init sequence supporting slave cores#43
Merged
lgirdwood merged 1 commit intothesofproject:nextfrom Jul 4, 2018
Merged
Conversation
lgirdwood
requested changes
Jul 3, 2018
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Just minor, our do_task_on_core() APIs should accept the core ID as an arg, that way we reduce the number of API calls and any conditional logic surrounding the API calls.
Member
There was a problem hiding this comment.
probably better if we can pass the core ID in here an use a single API call. We can also define PLATFORM_MASTER_CORE 0 if needed too
Contributor
Author
|
Changed the methods according to your suggestion. |
lgirdwood
reviewed
Jul 3, 2018
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Sorry, my mistake, I had misread the do_task() as a scheduling API update for slave core and now I see it the main loop. I think your original was better. OK to change back ? Sorry.
Change initialization sequence to support slave cores. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Contributor
Author
|
Reverted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change initialization sequence to support slave cores.
Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com