Skip to content

memory: apl: extend system heap#438

Merged
lgirdwood merged 1 commit intothesofproject:masterfrom
tlauda:topic/apl-extend-system-heap
Sep 29, 2018
Merged

memory: apl: extend system heap#438
lgirdwood merged 1 commit intothesofproject:masterfrom
tlauda:topic/apl-extend-system-heap

Conversation

@tlauda
Copy link
Copy Markdown
Contributor

@tlauda tlauda commented Sep 28, 2018

Extends system heap for core 0 to match other platforms.
Needed as total size of objects allocated on system heap
constantly changes and causes out of memory during slave
core enablement.

Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com

Extends system heap for core 0 to match other platforms.
Needed as total size of objects allocated on system heap
constantly changes and causes out of memory during slave
core enablement.

Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Copy link
Copy Markdown

@mmaka1 mmaka1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean HEAP_SYSTEM_1_SIZE? '0' is for core#0 while '1' is used by the slave core #1.

@tlauda
Copy link
Copy Markdown
Contributor Author

tlauda commented Sep 28, 2018

@mmaka1 Some structs are allocated for slave cores by master core before boot.

@mmaka1
Copy link
Copy Markdown

mmaka1 commented Sep 29, 2018

@tlauda Perhaps we want to make all these slave core data to be allocated from the slave core's heap in order to free them all when the slave core goes down as a future improvement? Freeing the slave core's sys heap by powering assigned memory bank(s) down would be possible on some platforms.

@lgirdwood lgirdwood merged commit 3ae5e63 into thesofproject:master Sep 29, 2018
@tlauda
Copy link
Copy Markdown
Contributor Author

tlauda commented Sep 30, 2018

@mmaka1 Sounds good. I will do it as the next improvement.

@tlauda tlauda deleted the topic/apl-extend-system-heap branch November 22, 2019 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants