Skip to content

plat: apl: clocks gated back on topology free#472

Merged
lgirdwood merged 1 commit intothesofproject:masterfrom
mmaka1:clk-gating-put
Oct 10, 2018
Merged

plat: apl: clocks gated back on topology free#472
lgirdwood merged 1 commit intothesofproject:masterfrom
mmaka1:clk-gating-put

Conversation

@mmaka1
Copy link
Copy Markdown

@mmaka1 mmaka1 commented Oct 8, 2018

Signed-off-by: Marcin Maka marcin.maka@linux.intel.com

@mmaka1
Copy link
Copy Markdown
Author

mmaka1 commented Oct 8, 2018

@lgirdwood This is implementation of the put-side for the dma and dai devices (see the #452).

While testing, I found that the ssp dai was not removed at the end as expected (3 refs obtained and 1 left). There was Tx dai comp, Rx dai comp, and the third unbalanced one appeared to be the IPC ipc_dai_config() handler. It is not a big deal to add the 'put' operation at the end of the handler but there is another thing. It might be more reliable to introduce 'CREATE' flag to dai_get() and dma_get(), so that the components specify CREATE meaning the object should be 'probed' if does not exist while the IPC config handlers should request only the existing objects and fail otherwise. It is to avoid a scenario, and fail early, where the driver implementation would incorrectly call (1) config first and then the (2) dai component new, so that the device would be (1) created-configured-destroyed, and then (2) created-and-used-unconfigured.

@mmaka1 mmaka1 force-pushed the clk-gating-put branch 2 times, most recently from a72429f to 98d0e90 Compare October 8, 2018 20:09
@mmaka1 mmaka1 requested a review from lgirdwood October 8, 2018 20:09
Signed-off-by: Marcin Maka <marcin.maka@linux.intel.com>
@lgirdwood lgirdwood merged commit 2bcafb7 into thesofproject:master Oct 10, 2018
@mmaka1 mmaka1 deleted the clk-gating-put branch October 12, 2018 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants