test: Partially fixed alloc unit tests#481
Merged
lgirdwood merged 1 commit intothesofproject:masterfrom Oct 14, 2018
Merged
Conversation
Unfortunately tests for buffer/runtime zones will remain broken, might require some rework in the firmware code. For this reason, they shall be temporarily disabled. Signed-off-by: Slawomir Blauciak <slawomir.blauciak@linux.intel.com>
jajanusz
approved these changes
Oct 11, 2018
Contributor
jajanusz
left a comment
jajanusz
left a comment
There was a problem hiding this comment.
@slawblauciak
Good job, thanks.
@lgirdwood
As Slawek wrote we don't test cases that need to be launched on slave cores (xt simulator runs only on master core) or that need specific memory features that are only available on dsp and not in simulator. Maybe we will be able to tests them later when we enable qemu support.
Member
|
@jajanusz yep, qemu can support > 1 core on xtensa so we could test these on xtensa as part of CI. |
|
@lgirdwood KW detected the issue, but later it was marked by @dabekjakub ( false positive ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately tests for buffer/runtime zones will remain broken,
might require some rework in the firmware code.
For this reason, they shall be temporarily disabled.
Signed-off-by: Slawomir Blauciak slawomir.blauciak@linux.intel.com