Skip to content

dai: ssp: dynamic device descriptor initialization#488

Merged
lgirdwood merged 1 commit intothesofproject:masterfrom
mmaka1:ssp-init
Oct 19, 2018
Merged

dai: ssp: dynamic device descriptor initialization#488
lgirdwood merged 1 commit intothesofproject:masterfrom
mmaka1:ssp-init

Conversation

@mmaka1
Copy link
Copy Markdown

@mmaka1 mmaka1 commented Oct 12, 2018

This is a first step for run-time HW discovery on cavs
platforms.

Signed-off-by: Marcin Maka marcin.maka@linux.intel.com

@mmaka1 mmaka1 requested review from lgirdwood and tlauda October 12, 2018 15:27
Comment thread src/platform/intel/cavs/dai.c Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmaka1 is the intention that this will be on the heap and created dynamically for each DAI if it's used in topology ?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgirdwood The descriptors (above) are still created during the platform initialization to be registered in the lib layer. Since they are statically defined atm, they are just moved from .data to .bss by this patch. The platform headers define the quantity. This is a step towards dynamic allocation of the descriptors from the heap during run-time discovery (using HW caps registers).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, btw - looks like there is a conflict now

@mmaka1 mmaka1 force-pushed the ssp-init branch 3 times, most recently from 44f4999 to 9cd1e80 Compare October 17, 2018 07:18
This is a first step for run-time HW discovery on cavs
platforms.

Signed-off-by: Marcin Maka <marcin.maka@linux.intel.com>
@mmaka1
Copy link
Copy Markdown
Author

mmaka1 commented Oct 19, 2018

@lgirdwood No merge conflicts atm. Are 0-day for BYT blocking?

@lgirdwood lgirdwood merged commit 6baff99 into thesofproject:master Oct 19, 2018
@mmaka1 mmaka1 deleted the ssp-init branch October 29, 2018 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants