Set SRAM LDO off on power down - additional power gating on D0->D3 path.#500
Merged
lgirdwood merged 1 commit intothesofproject:masterfrom Oct 25, 2018
Merged
Conversation
lgirdwood
requested changes
Oct 19, 2018
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Minor change to make it obvious for anyone trying to include this in C sources.
Member
There was a problem hiding this comment.
best to say #error "header can only be used by assembly sources"
Collaborator
Author
There was a problem hiding this comment.
changes applied to the PR
lbetlej
force-pushed
the
ldo_off_on_power_down
branch
3 times, most recently
from
05c4fdc to
cd8c78d
Compare
lbetlej
changed the title
lbetlej
force-pushed
the
ldo_off_on_power_down
branch
from
cd8c78d to
dfcf50c
Compare
lgirdwood
requested changes
Oct 24, 2018
Member
There was a problem hiding this comment.
github is showing a warning about no newline at end of file here.
Added assembly macros to control state of LDO for LP and HP SRAM. Macros are used during power down procedure to properly handle LDO state. LDO handling sequence in power down procedure is specific for cAVS 1.5. Signed-off-by: Lech Betlej <lech.betlej@linux.intel.com>
lbetlej
force-pushed
the
ldo_off_on_power_down
branch
from
dfcf50c to
d5c3828
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added assembly macros to control state of LDO for LP and HP SRAM.
Macros are used during power down procedure to properly handle LDO state.
Signed-off-by: Lech Betlej lech.betlej@linux.intel.com