Volume: Fix overflow in s16 and s24 output conversions#528
Merged
lgirdwood merged 1 commit intothesofproject:masterfrom Nov 6, 2018
Merged
Volume: Fix overflow in s16 and s24 output conversions#528lgirdwood merged 1 commit intothesofproject:masterfrom
lgirdwood merged 1 commit intothesofproject:masterfrom
Conversation
The problem could be heard with extremely loud music content. The 32x32 saturating multiply function works for 32 bit output but the result will overflow when less number of bits are used from output. This patch adds to format.h rounded 32x32 multiply inline functions for saturated s24 and s16 formats. The generic volume function is updated to utilize them and the code structure is cleaned for easier maintenance and simpler look. The format.h file is cleaned up with function parameter indents and remove of redundant code in saturate function. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Collaborator
Author
|
This fixes issue #416. |
lgirdwood
approved these changes
Nov 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem could be heard with extremely loud music content. The
32x32 saturating multiply function works for 32 bit output but
the result will overflow when less number of bits are used from output.
This patch adds to format.h rounded 32x32 multiply inline functions for
saturated s24 and s16 formats. The generic volume function is updated
to utilize them and the code structure is cleaned for easier maintenance
and simpler look.
The format.h file is cleaned up with function parameter indents and
remove of redundant code in saturate function.
Signed-off-by: Seppo Ingalsuo seppo.ingalsuo@linux.intel.com