[RFC] CMake: pass firmware file micro version to rimage#5759
Closed
mengdonglin wants to merge 2 commits into
Closed
[RFC] CMake: pass firmware file micro version to rimage#5759mengdonglin wants to merge 2 commits into
mengdonglin wants to merge 2 commits into
Conversation
* Use %z specifier for size types to avoid format specifier warnings on arm32 * in ctl_dump(), size_t n may be used uninitialized if ctl_data->out_fd > 0 and !ctl_data->binary. Signed-off-by: Li-Yu Yu <aaronyu@google.com>
SOF CMake defines SOF_MAJOR, SOF_MINOR and SOF_MICRO for 3 fields of firmware file version major.minor.micro. But CMake only passes the major and minor version to rimage. Now CMake will also pass the mirco version to rimage, so that rimage can write it to different firmware manifest headers for cAVS platforms and then sof_ri_info.py will be able to dump entire file version info from the firmware binary. Signed-off-by: Mengdong Lin <mengdong.lin@intel.com>
mengdonglin
requested review from
aborisovich,
marc-hb and
singalsu
as code owners
Collaborator
Author
|
This PR includes another commit by mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #5693
This PR depends on thesofproject/rimage#91, which needs to be merged at first
SOF CMake defines SOF_MAJOR, SOF_MINOR and SOF_MICRO for 3 fields of
firmware file version major.minor.micro. But CMake only passes the major
and minor version to rimage.
Now CMake will also pass the mirco version to rimage, so that rimage can
write it to different firmware manifest headers for cAVS platforms and
then sof_ri_info.py will be able to dump entire file version info from
the firmware binary.