RTNR: Decouple switch-enable control from params blob#5768
Conversation
MingJenTai
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
|
SOFCI TEST |
|
Rerun CI as there were some recent build fixes merged for Zephyr update. |
|
Try ci again. |
|
@marc-hb Zephyr build reporting the toolchain is not found. Do we need to rebase and force push to correct this ? |
|
Can one of the admins verify this patch? |
You never need to rebase. Most common CI misconception. All CI engines used here do a git merge with the (moving!) target branch before testing. What you need is my brand new AFTER #5831 is approved and merged then a simple and empty |
@MingJenTai #5381 is merged now so pls do above. Thanks. |
MingJenTai
force-pushed
the
adl-004-drop-stable_RTNR_fix_control_switch
branch
from
178336d to
62ac80e
Compare
This PR is based on thesofproject#5616 It decouples the switch-typed control for enabling/disabling from the control bytes. Previously, control blobs should be sent from userspace to to toggle RTNR on/off. With this PR, RTNR can be toggled by setting the UCM switch value. cset "name='RTNR10.0 rtnr_enable_10' off" cset "name='RTNR10.0 rtnr_enable_10' on" or from command line amixer -c0 cset name='RTNR10.0 rtnr_enable_10' 1 amixer -c0 cget name='RTNR10.0 rtnr_enable_10' 0 Signed-off-by: Pin-chih Lin <johnylin@google.com> Signed-off-by: Ming Jen Tai <mingjen_tai@realtek.com> merge copy_func Cherry-picked from 2e6bfbe
MingJenTai
force-pushed
the
adl-004-drop-stable_RTNR_fix_control_switch
branch
from
62ac80e to
8bef242
Compare
@lgirdwood Done. Please check if this works. Thanks. |
|
Zephyr builds on Github are now fixed as expected https://github.com/thesofproject/sof/runs/6499676276?check_suite_focus=true The Zephyr builds on sof-ci/jenkins are still broken as expected because of known internal issue 215 (sof-ci/jenkins always overrides the default Zephyr version/branch with Zephyr main) Similar problem with https://sof-ci.01.org/sof-pr-viewer/#/build/PR5768/build9374092 which requires some recent IPC4 stuff not on this branch. |
|
Retry CI with recent fixes. |
|
SOFCI TEST |
|
@mwasko fyi non topology backport for ADL 04. CI does not work for some older branches. Ples review/merge as you see fit. |
@MingJenTai can you confirm that this changes was verified on this branch? |
Yes this has been tested and verified on this branch, thank you! |
5 participants
This PR is based on #5616
It decouples the switch-typed control for enabling/disabling from the control bytes.
Previously, control blobs should be sent from userspace to to toggle RTNR on/off.
With this PR, RTNR can be toggled by setting the UCM switch value.
cset "name='RTNR10.0 rtnr_enable_10' off"
cset "name='RTNR10.0 rtnr_enable_10' on"
or from command line
amixer -c0 cset name='RTNR10.0 rtnr_enable_10' 1
amixer -c0 cget name='RTNR10.0 rtnr_enable_10' 0
Signed-off-by: Pin-chih Lin johnylin@google.com
Signed-off-by: Ming Jen Tai mingjen_tai@realtek.com
Cherry-picked from 2e6bfbe