several cosmetic, simplification and optimisation patches#6103
Merged
lgirdwood merged 4 commits intothesofproject:mainfrom Aug 8, 2022
Merged
several cosmetic, simplification and optimisation patches#6103lgirdwood merged 4 commits intothesofproject:mainfrom
lgirdwood merged 4 commits intothesofproject:mainfrom
Conversation
On multiple occasions local variables are used for only one intermediate operation and can easily be eliminated with no loss of clarity. This increases code density to allow better overview. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Instead of allocating channel data for each channel separately, allocate them in a single array. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Eliminate an unneeded negation in a test and use existing local variables, instead of re-calculating list pointers. Also use list_for_item() instead of open-coding it. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lyakh
requested review from
bardliao,
dbaluta,
lbetlej,
lgirdwood,
marcinszkudlinski,
mmaka1,
plbossart and
singalsu
as code owners
lgirdwood
approved these changes
Aug 5, 2022
abonislawski
approved these changes
Aug 6, 2022
dbaluta
approved these changes
Aug 8, 2022
marcinszkudlinski
approved these changes
Aug 8, 2022
tmleman
approved these changes
Aug 8, 2022
Collaborator
|
There is a build error for zephyr: https://github.com/thesofproject/sof/runs/7693465559?check_suite_focus=true Not sure if it is related with this PR, though. https://github.com/thesofproject/sof/runs/7693465559?check_suite_focus=true |
Member
|
@lyakh I think you may need to force push again as the Zephyr build error fix was probably merged after your PR CI was run. |
singalsu
approved these changes
Aug 8, 2022
Previous commits removed code but left several empty lines behind, remove two of them. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 memory allocation optimisation, some list manipulation improvements and misc. minor improvements