Add new topologies for PCM capture/playback using compress API#6142
Merged
dbaluta merged 6 commits intothesofproject:mainfrom Aug 17, 2022
Merged
Add new topologies for PCM capture/playback using compress API#6142dbaluta merged 6 commits intothesofproject:mainfrom
dbaluta merged 6 commits intothesofproject:mainfrom
Conversation
This change will allow us to prepare for adding a new macro for the case of compress capture. Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
We want to be able to create topologies for the case of compress capture. This change will enable us to do so. Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
LaurentiuM1234
requested review from
aborisovich,
dbaluta,
lbetlej,
lgirdwood,
marc-hb,
mmaka1 and
plbossart
as code owners
dbaluta
reviewed
Aug 16, 2022
tools/topology/topology1/development/sof-imx8-compr-pcm-wm8960.m4
Outdated
Show resolved
Hide resolved
dbaluta
reviewed
Aug 16, 2022
tools/topology/topology1/development/sof-imx8-compr-pcm-wm8960.m4
Outdated
Show resolved
Hide resolved
tools/topology/topology1/development/sof-imx8-compr-pcm-wm8960.m4
Outdated
Show resolved
Hide resolved
LaurentiuM1234
force-pushed
the
compress_pcm_topologies
branch
from
713bab4 to
235f9fa
Compare
lgirdwood
approved these changes
Aug 16, 2022
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
@LaurentiuM1234 @dbaluta LGTM, but do we need to merge any FW/driver patches first ?
Collaborator
|
@lgirdwood not really. I mean we do need thesofproject/linux#3821 driver change for capture pipeline to work but the order of merge is not really relevant. This is ready to be merged after @LaurentiuM1234 fixes my last comment. |
dbaluta
reviewed
Aug 17, 2022
tools/topology/topology1/development/sof-imx8-compr-pcm-wm8960.m4
Outdated
Show resolved
Hide resolved
We add a new i.MX8Q(M/XP) topology which will use the compress API for PCM playback. This topology is mainly used for testing. Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
LaurentiuM1234
force-pushed
the
compress_pcm_topologies
branch
from
235f9fa to
ab44382
Compare
We add a new i.MX8Q(M/XP) topology which will use the compress API for PCM capture. This topology is mainly used for testing. Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
We add a new i.MX8MP topology which will use the compress API for PCM playback. This topology is mainly used for testing. Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
We add a new i.MX8MP topology which will use the compress API for PCM capture. This topology is mainly used for testing. Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
paulstelian97
approved these changes
Aug 17, 2022
Collaborator
paulstelian97
left a comment
paulstelian97
left a comment
There was a problem hiding this comment.
Approving as-is, will consider implementing the changes I proposed myself later on.
dbaluta
approved these changes
Aug 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this series of patches is to introduce new topologies that make use of the compress API in order to play/capture using the PCM format. This is mostly used to test the compress API.