rtnr: Set process_enabled by default and keep its value in rtnr_reset() #6148
Merged
lgirdwood merged 1 commit intothesofproject:mainfrom Aug 17, 2022
Merged
Conversation
MingJenTai
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
dbaluta
reviewed
Aug 17, 2022
dbaluta
approved these changes
Aug 17, 2022
MingJenTai
force-pushed
the
main_rtnr_set_default_on
branch
from
e4313cc to
71a9318
Compare
MingJenTai
changed the title
Since rtnr_reset() will be called once recording is finished, the value of process_enabled should not be changed in this function. Otherwise every new recording will start with the value set in rtnr_reset(), and it should be an incorrect behavior. Signed-off-by: Ming Jen Tai <mingjen_tai@realtek.com>
MingJenTai
force-pushed
the
main_rtnr_set_default_on
branch
from
71a9318 to
c4c13d4
Compare
lgirdwood
approved these changes
Aug 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables RTNR processing by default and keeps its value while the recording is finished.
Since rtnr_reset() will be called once recording is finished, the value of process_enabled should not be changed in this function.
Otherwise every new recording will start with the value set in rtnr_reset() and it should be an incorrect behavior.