Skip to content

platform: imx: Set PLATFORM_DCACHE_ALIGN to 32#6182

Merged
lgirdwood merged 1 commit intothesofproject:mainfrom
dbaluta:fix_dcache_align
Aug 25, 2022
Merged

platform: imx: Set PLATFORM_DCACHE_ALIGN to 32#6182
lgirdwood merged 1 commit intothesofproject:mainfrom
dbaluta:fix_dcache_align

Conversation

@dbaluta
Copy link
Collaborator

@dbaluta dbaluta commented Aug 24, 2022

Ideally PLATFORM_DCACHE_ALIGN should be equal with DCACHE_LINE_SIZE,
but on i.MX dcache line size is 128 and it is too big for XTOS based
memory allocator.

See commit 8354454 ("platform: imx: Fix PLATFORM_DCACHE_ALIGN")

On the other hand the current value which is 4 doesn't work well with
Zephyr.

So, increase the PLATFORM_DCACHE_ALIGN to 32 which works well for XTOS /
Zephyr.

Signed-off-by: Daniel Baluta daniel.baluta@nxp.com

Ideally PLATFORM_DCACHE_ALIGN should be equal with DCACHE_LINE_SIZE,
but on i.MX dcache line size is 128 and it is too big for XTOS based
memory allocator.

See commit 8354454 ("platform: imx: Fix PLATFORM_DCACHE_ALIGN")

On the other hand the current value which is 4 doesn't work well with
Zephyr.

So, increase the PLATFORM_DCACHE_ALIGN to 32 which works well for XTOS /
Zephyr.

Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess your Zephyr SOC headers will use the 128 value ?

@dbaluta
Copy link
Collaborator Author

dbaluta commented Aug 24, 2022

I guess your Zephyr SOC headers will use the 128 value ?

Yes, this would be ideal. But for now even with zephyr we use PLATFORM_DCACHE_ALIGN pulled in from:

./src/include/sof/lib/memory.h -> /src/platform/imx8m/include/platform/lib/memory.h

Eventually we will get to the point where PLATFORM_DCACHE_ALIGN will be pulled in from Zephyr SOC headers.

@lgirdwood
Copy link
Member

More time wasted with xcc licences.

License checkout failed: No such feature exists.
Feature:       XTENSA_XCC_TIE
License path:  84300@xtensa01p.elic.intel.com:/srv/home/jenkins/xcc/install/tools/RD-2012.5-linux/XtensaTools/Tools/lic/license.dat:
FLEXnet Licensing error:-5,147
For further information, refer to the FLEXnet Licensing documentation,
available at "www.macrovision.com".
make[3]: *** [CMakeFiles/sof.dir/build.make:202: CMakeFiles/sof.dir/src/arch/xtensa/schedule/schedule.c.o] Error 2
make[3]: *** Waiting for unfinished jobs....
License checkout failed: No such feature exists.

@lgirdwood
Copy link
Member

SOFCI TEST

@lgirdwood lgirdwood merged commit 4dbfe15 into thesofproject:main Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants