platform: imx: Set PLATFORM_DCACHE_ALIGN to 32#6182
Merged
lgirdwood merged 1 commit intothesofproject:mainfrom Aug 25, 2022
Merged
platform: imx: Set PLATFORM_DCACHE_ALIGN to 32#6182lgirdwood merged 1 commit intothesofproject:mainfrom
lgirdwood merged 1 commit intothesofproject:mainfrom
Conversation
Ideally PLATFORM_DCACHE_ALIGN should be equal with DCACHE_LINE_SIZE, but on i.MX dcache line size is 128 and it is too big for XTOS based memory allocator. See commit 8354454 ("platform: imx: Fix PLATFORM_DCACHE_ALIGN") On the other hand the current value which is 4 doesn't work well with Zephyr. So, increase the PLATFORM_DCACHE_ALIGN to 32 which works well for XTOS / Zephyr. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
lgirdwood
approved these changes
Aug 24, 2022
Member
lgirdwood
left a comment
There was a problem hiding this comment.
I guess your Zephyr SOC headers will use the 128 value ?
Collaborator
Author
Yes, this would be ideal. But for now even with zephyr we use PLATFORM_DCACHE_ALIGN pulled in from: ./src/include/sof/lib/memory.h -> /src/platform/imx8m/include/platform/lib/memory.h Eventually we will get to the point where PLATFORM_DCACHE_ALIGN will be pulled in from Zephyr SOC headers. |
Member
|
More time wasted with xcc licences. |
Member
|
SOFCI TEST |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally PLATFORM_DCACHE_ALIGN should be equal with DCACHE_LINE_SIZE,
but on i.MX dcache line size is 128 and it is too big for XTOS based
memory allocator.
See commit 8354454 ("platform: imx: Fix PLATFORM_DCACHE_ALIGN")
On the other hand the current value which is 4 doesn't work well with
Zephyr.
So, increase the PLATFORM_DCACHE_ALIGN to 32 which works well for XTOS /
Zephyr.
Signed-off-by: Daniel Baluta daniel.baluta@nxp.com