cpu: enabling and disabling slave cores#66
Merged
lgirdwood merged 1 commit intothesofproject:nextfrom Jul 10, 2018
Merged
Conversation
lgirdwood
requested changes
Jul 9, 2018
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Just needs to be a little bit more xtensa generic
Member
There was a problem hiding this comment.
This is not xtensa generic code but platform specific (the interrupts are probably better enabled by arch_cpu_enable_core() caller).
Member
There was a problem hiding this comment.
This declaration need to be at top of function.
Implements full flow for enabling and disabling slave cores. Core power operations availability based on architecture. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
tlauda
force-pushed
the
topic/cpu_enable_core
branch
from
d8cea45 to
b4004e8
Compare
Contributor
Author
|
Moved idc interrupt enabling to arch/idc.h, but I believe it's still better to call it from arch_cpu_enable_core(). Generally it's really hard to create the line between arch and platform, since platform forces us to use specific arch. In case of multicore and idc, calling hierarchy is from generic -> platform -> arch, so we can directly use methods from arch/idc.h in arch/cpu.c. |
lgirdwood
approved these changes
Jul 10, 2018
ryans-lee
pushed a commit
to ryans-lee/sof
that referenced
this pull request
Jul 6, 2020
Signed-off-by: Ryan Lee <ryans.lee@maximintegrated.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements full flow for enabling and disabling
slave cores. Core power operations availability
based on architecture.
Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com