Topology2: sdw-amp-generic: add missing num_input_pins#7900
Merged
ranj063 merged 1 commit intothesofproject:mainfrom Jul 6, 2023
Merged
Topology2: sdw-amp-generic: add missing num_input_pins#7900ranj063 merged 1 commit intothesofproject:mainfrom
ranj063 merged 1 commit intothesofproject:mainfrom
Conversation
num_input_pins was missing in passthrough mode. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Collaborator
@plbossart unfortunately not with this one because num_input_pins is not mandatory for the copier. |
ranj063
approved these changes
Jul 6, 2023
Member
What prevents us from making it mandatory? I thought the two sides are needed for DMA config and buffer config. |
Collaborator
I can look into it in a follow up PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
num_input_pins was missing in passthrough mode.
Fixes: #7899