[SKIP CI]github action: remove duplicate build for TGL/TGL-H#8261
Merged
Conversation
aiChaoSONG
requested review from
cujomalainey,
dbaluta,
lgirdwood and
marc-hb
as code owners
lgirdwood
approved these changes
Sep 26, 2023
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
@keqiaozhang @marc-hb can we proceed and remove the duplication now ?
marc-hb
previously requested changes
Sep 26, 2023
Collaborator
There was a problem hiding this comment.
Thanks @aiChaoSONG for the cleanup and very detailed commit message.
There are still some obsolete comments like "# Very few IPC3 platforms support IPC4 too.". That's not true any more, I think the count is now zero.
Almost there!
At the beginning, we have two build jobs in github action to build IPC3 and IPC4 firmware for TGL/TGL-H. The PR thesofproject#8048 switches cAVS2.5 configs to use IPC4 by default and empties the cAVS2.5 overlay files. After the change, the xtensa-build-zephyr.py script is building the same IPC4 firmware with or without '-i IPC4' option. So we have two jobs running different build command but build the same IPC4 firmware. Recently, commit 5004d0f ("zephyr.yml: remove ipc option for zephyr build") removes '-i IPC4' option in github action for TGL/TGL-H IPC4 build. So we have duplicated jobs to build firmware for TGL and TGL-H in the end. This patch removes the duplicated build job which previously is used to build IPC3 firmware for TGL/TGL-H and obsolete comments. Signed-off-by: Chao Song <chao.song@linux.intel.com>
marc-hb
approved these changes
Sep 27, 2023
tmleman
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the beginning, we have two build jobs in github action to build IPC3 and IPC4 firmware for TGL/TGL-H.
The PR #8048 switches cAVS2.5 configs to use IPC4 by default and empties the cAVS2.5 overlay files. After the change, the xtensa-build-zephyr.py script is building the
same IPC4 firmware with or without '-i IPC4' option. So we have two jobs running different build command but build the same IPC4 firmware.
Recently, commit 5004d0f ("zephyr.yml: remove ipc option for zephyr build") removes '-i IPC4' option in github action for TGL/TGL-H IPC4 build. So we have duplicated jobs to build firmware for TGL and TGL-H now.
This patch removes the duplicated build job which previously is used to build IPC3 firmware for TGL/TGL-H.