[SKIP SOF-TEST] scripts/fuzz.sh: fix multiple issues with "stub" overlays#8411
Merged
lgirdwood merged 1 commit intothesofproject:mainfrom Oct 31, 2023
Merged
[SKIP SOF-TEST] scripts/fuzz.sh: fix multiple issues with "stub" overlays#8411lgirdwood merged 1 commit intothesofproject:mainfrom
lgirdwood merged 1 commit intothesofproject:mainfrom
Conversation
marc-hb
changed the title
Fixes commit deed9a8 ("scripts: fuzz: add support for build and overlays") The main issue was the way fuzz.sh was trying to parse the overlay file. Drop that and just pass it as is to `west` and `cmake` instead, they know what to do with it. Also: - Fix invalid syntax in stub_build_all_ipc4.conf - Make fuzz.sh shellcheck-clean again. Always use shellcheck. - Temporarily disable `CONFIG_COMP_SMART_AMP` in stub_build_all_ipc3.conf because `smart_amp.c` does not compile (in any configuration) ``` sof/src/audio/smart_amp/smart_amp.c:748:9: error: no member named 'in_channels' in 'struct smart_amp_data' sad->in_channels = audio_stream_get_channels(&source_buffer->stream); ``` Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
force-pushed
the
fix-fuzz-stubs
branch
from
6e16340 to
956043f
Compare
marc-hb
requested review from
cujomalainey,
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
This was referenced Oct 28, 2023
cujomalainey
approved these changes
Oct 30, 2023
lgirdwood
approved these changes
Oct 31, 2023
marc-hb
commented
Oct 31, 2023
| # temporarily disabled until it compiles: | ||
| # sof/src/audio/smart_amp/smart_amp.c:748:9: error: | ||
| # no member named 'in_channels' in 'struct smart_amp_data' | ||
| # sad->in_channels = audio_stream_get_channels(&source_buffer->stream); |
Collaborator
Author
There was a problem hiding this comment.
@johnylin76 can you fix smart_amp.c compilation and re-enable?
EDIT: good at last?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes commit deed9a8 ("scripts: fuzz: add support for build and overlays")
The main issue was the way fuzz.sh was trying to parse the overlay file. Drop that and just pass it as is to
westandcmakeinstead, they know what to do with it.Also:
CONFIG_COMP_SMART_AMPin stub_build_all_ipc3.conf becausesmart_amp.cdoes not compile (in any configuration)