app/stub*.conf: add CONFIG_SAMPLE_SMART_AMP=y #8425
Merged
kv2019i merged 4 commits intothesofproject:mainfrom Nov 2, 2023
Merged
app/stub*.conf: add CONFIG_SAMPLE_SMART_AMP=y #8425kv2019i merged 4 commits intothesofproject:mainfrom
kv2019i merged 4 commits intothesofproject:mainfrom
Conversation
Don't be creative with weird "visible if" syntax. Simply don't include sub-Kconfig when the top-level option is disabled. This removes "backdoors" like: -DCONFIG_SAMPLE_SMART_AMP=y -DCONFIG_SAMPLES=n "In Rome, do as the Romans do" Fixes commit 03b80ea ("audio: move test components into the src/samples/audio dir") Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This reverts commit fbde1dc. Now that CONFIG_SAMPLE_SMART_AMP has a hard, menu dependency on CONFIG_SAMPLES, we don't need to encode Kconfig dependencies in CMake any more. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Fixes commit f06da57 ("smart_amp: add smart amplifier test component") which added its COMP_TEST_SMART_AMP ancestor. This code can compile without any hardware dependency; `git show ___ | grep include` does not show any. This is useful for fuzzing etc. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
While one smart_amp C file does not compile, let's keep compile-checking the other two. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
marc-hb
requested review from
aiChaoSONG,
andyross,
bkokoszx,
cujomalainey,
johnylin76 and
lyakh
lyakh
approved these changes
Nov 2, 2023
Collaborator
|
@marc-hb @lgirdwood I don't understand why this happens, but I suspect that some this PR and #8426 , when both now merged, is causing IPC3 stub build fails in mainline now. Probably something simple, but shows up in every PR. |
Collaborator
Author
|
I made the same guess as @kv2019i . I will confirm and submit some solution today, one way or the other. |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4 very small commits but review commit by commit is required.